You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/19 18:02:07 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #1946: HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION
adoroszlai opened a new pull request #1946:
URL: https://github.com/apache/ozone/pull/1946
## What changes were proposed in this pull request?
HDDS-4731 missed some places related to file status where client version needs to be considered for protobuf conversion. These can be reproduced by `ozone fs` operations:
```
$ ozone fs -mkdir o3fs://bucket1.vol1/dir/
$ ozone fs -ls o3fs://bucket1.vol1/dir/
$ ozone fs -put /etc/passwd o3fs://bucket1.vol1/dir/
-put: No enum constant org.apache.hadoop.hdds.protocol.DatanodeDetails.Port.Name.REPLICATION
$ ozone fs -ls o3fs://bucket1.vol1/dir/
-ls: No enum constant org.apache.hadoop.hdds.protocol.DatanodeDetails.Port.Name.REPLICATION
```
https://issues.apache.org/jira/browse/HDDS-4851
## How was this patch tested?
Added acceptance test cases. 0.5.0 client had to be removed from the test due to another incompatibility:
```
Message missing required fields: getFileStatusResponse.status.status, ...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] swagle merged pull request #1946: HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION
Posted by GitBox <gi...@apache.org>.
swagle merged pull request #1946:
URL: https://github.com/apache/ozone/pull/1946
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] avijayanhwx commented on a change in pull request #1946: HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on a change in pull request #1946:
URL: https://github.com/apache/ozone/pull/1946#discussion_r579515829
##########
File path: hadoop-ozone/dist/src/main/compose/xcompat/clients.yaml
##########
@@ -17,15 +17,6 @@
version: "3.4"
services:
- old_client_0_5_0:
Review comment:
Can you provide some context on why this has been removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1946: HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1946:
URL: https://github.com/apache/ozone/pull/1946#issuecomment-782588335
Thanks @avijayanhwx and @swagle for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #1946: HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1946:
URL: https://github.com/apache/ozone/pull/1946#discussion_r579624716
##########
File path: hadoop-ozone/dist/src/main/compose/xcompat/clients.yaml
##########
@@ -17,15 +17,6 @@
version: "3.4"
services:
- old_client_0_5_0:
Review comment:
From PR description:
> 0.5.0 client had to be removed from the test due to another incompatibility:
>
> ```
> Message missing required fields: getFileStatusResponse.status.status, ...
> ```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] swagle commented on pull request #1946: HDDS-4851. More compatibility problem with DatanodeDetails.Port.Name.REPLICATION
Posted by GitBox <gi...@apache.org>.
swagle commented on pull request #1946:
URL: https://github.com/apache/ozone/pull/1946#issuecomment-782461350
Thanks for the review @avijayanhwx committing this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org