You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2014/09/04 04:25:13 UTC

[GitHub] spark pull request: [SPARK-2873] [SQL] using ExternalAppendOnlyMap...

Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/2029#issuecomment-54396074
  
    What were the actual results of the benchmark?  It is acceptable for there to be some performance hit here.  In cases where there are too many keys, its much better to spill to disk than to OOM, though you have a good point about just adding more partitions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org