You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Paul Elschot (JIRA)" <ji...@apache.org> on 2008/05/29 22:15:44 UTC
[jira] Created: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Allow use of compact DocIdSet in CachingWrapperFilter
-----------------------------------------------------
Key: LUCENE-1296
URL: https://issues.apache.org/jira/browse/LUCENE-1296
Project: Lucene - Java
Issue Type: New Feature
Components: Search
Reporter: Paul Elschot
Priority: Minor
Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1296:
---------------------------------------
Attachment: LUCENE-1296.patch
Paul, I reverted the changes to ChainedFilter & BooleanFilter, and instead deprecated the new finalResult method. It's dangerous to just remove protected methods since on upgrading there will be no errors but, silently, the finalResult method will no longer be called. I think in 3.0 when we remove these methods, rather than simply removing them we should actually mark them final such that any subclasses still using them will see hard compilation errors.
Can you look over the new patch?
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, LUCENE-1296.patch, LUCENE-1296.patch, LUCENE-1296b.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1296) Allow use of compact
DocIdSet in CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600911#action_12600911 ]
paul.elschot@xs4all.nl edited comment on LUCENE-1296 at 5/29/08 1:22 PM:
---------------------------------------------------------------
Once more, with licence and copyright assigned to ASF.
was (Author: paul.elschot@xs4all.nl):
Once more, with ASF.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: cachedFilter20080529.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601699#action_12601699 ]
Paul Elschot commented on LUCENE-1296:
--------------------------------------
For the record: the patch of 20080529 leaves some imports of SortedVIntList unused.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael Busch
> Priority: Minor
> Attachments: cachedFilter20080529.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624658#action_12624658 ]
Paul Elschot commented on LUCENE-1296:
--------------------------------------
I think this is ready to commit.
Even so, I'd like to repeat that it also removes the choice of another DocIdSet in the contrib search/BooleanFilter and misc/ChainedFilter.
In the latest patch, the actual choice of another DocIdSet is left to subclasses of CachingWrapperFilter that are not implemented.
One detail: for maximum flexibility, the 2nd argument to the protected method docIdSetToCache might be replaced by the indexreader. At the moment the 2nd arg is maxDoc of the indexreader, which is the only info I have needed so far to chose another DocIdSet.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1296:
---------------------------------
Attachment: (was: cachedFilter20080605.patch)
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael Busch
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1296:
---------------------------------
Attachment: cachedFilter20080529.patch
Once more, with ASF.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: cachedFilter20080529.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641968#action_12641968 ]
Michael McCandless commented on LUCENE-1296:
--------------------------------------------
Sigh. Should have marked it as 2.4 fix version :)
bq. One detail: for maximum flexibility, the 2nd argument to the protected method docIdSetToCache might be replaced by the indexreader.
+1
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649908#action_12649908 ]
Michael McCandless commented on LUCENE-1296:
--------------------------------------------
It looks like the patch removed finalResult from contrib's ChainedFilter but not from contrib's BooleanFilter?
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, LUCENE-1296.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1296) Allow use of compact
DocIdSet in CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600907#action_12600907 ]
paul.elschot@xs4all.nl edited comment on LUCENE-1296 at 6/3/08 12:11 PM:
---------------------------------------------------------------
The 20080529 patch patches CachingWrapperFilter and its test to add a choice of a compact filter to be cached, as well as some recently patched ( LUCENE-1187 ) contrib filter classes to remove the corresponding functionality there.
was (Author: paul.elschot@xs4all.nl):
The 20080529 patch patches CachingWrapperFilter and its test to add a choice of a compact filter to be cached, as well as some recently patched contrib filter classes to remove the corresponding functionality there.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael Busch
> Priority: Minor
> Attachments: cachedFilter20080529.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1296.
----------------------------------------
Resolution: Fixed
Lucene Fields: [New, Patch Available] (was: [Patch Available, New])
Committed revision 722174.
Thanks Paul!
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, LUCENE-1296.patch, LUCENE-1296.patch, LUCENE-1296b.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch reassigned LUCENE-1296:
-------------------------------------
Assignee: Michael Busch
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael Busch
> Priority: Minor
> Attachments: cachedFilter20080529.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601504#action_12601504 ]
Paul Elschot commented on LUCENE-1296:
--------------------------------------
I tried to come up with a sensible performance test to determine a good criterium to choose between OpenBitSet and SortedVIntList as the DocIdSet supporting data structure to be cached.
There is a criterium for this in the patch in docIdSetToCache() method of CachingWrapperFilter, but it's only based on byte size, and it favours SortedVIntList when it is defenitely more compact than OpenBitSet.
The current criterium is to use (cardinality (=nr bits set in OpenBitSet) < maxDocs/9) as a test to prefer SortedVIntList over OpenBitSet for caching. The constant 9 might be replaced by a configuration parameter to allow easy performance experiments there. It could be that a larger value than 9 is turns out to be "optimal" in runtime.
In some cases OpenBitSet can be faster on skipTo(int docNum) than SortedVIntList, even when SortedVIntList is more compact. As Filters can be expected to use skipTo() heavily, this could be important for performance.
Even even though it might be possible to measure the skipTo() performance directly, the effect of the more compact cached data structure of SortedVIntList on garbage collection is (pretty close to) impossible to measure in a simple test case.
Eks Dev had some interesting results there in the very early stages of LUCENE-584 (September 2006), so I wonder whether these results could be confirmed somehow using the patch here and the current trunk.
Comments?
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael Busch
> Priority: Minor
> Attachments: cachedFilter20080529.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1296:
---------------------------------
Attachment: cachedFilter20080605.patch
In the 20080605 patch the docIdSetToCache method simply returns its argument, which would normally be an OpenBitSet when using a Filter from the core. Anyone who wants to have another filter data structure cached can override this method.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael Busch
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1296:
---------------------------------
Attachment: (was: cachedFilter20080529.patch)
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652081#action_12652081 ]
Paul Elschot commented on LUCENE-1296:
--------------------------------------
Indeed it is better to be conservative about released things as in today's patch.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, LUCENE-1296.patch, LUCENE-1296.patch, LUCENE-1296b.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649816#action_12649816 ]
Michael McCandless commented on LUCENE-1296:
--------------------------------------------
Paul are you going to pull together another patch here?
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1296:
------------------------------------------
Assignee: Michael McCandless
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640832#action_12640832 ]
Paul Elschot commented on LUCENE-1296:
--------------------------------------
This didn't make it into 2.4.
A side effect of that is that SortedVIntList will somtimes be used instead of an OpenBitSet contrib search/BooleanFilter and misc/ChainedFilter. So far no problems have surfaced there, which is good news. I wonder if there was any performance improvement in practice because of this.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1296:
---------------------------------
Attachment: cachedFilter20080529.patch
The 20080529 patch patches CachingWrapperFilter and its test to add a choice of a compact filter to be cached, as well as some recently patched contrib filter classes to remove the corresponding functionality there.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1296:
---------------------------------
Attachment: cachedFilter20080605.patch
Once more, with licence granted to ASF.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael Busch
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch reassigned LUCENE-1296:
-------------------------------------
Assignee: (was: Michael Busch)
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646954#action_12646954 ]
Paul Elschot commented on LUCENE-1296:
--------------------------------------
{quote}Also, why not put your logic to sometimes choose a SortedVIntList impl intoCachingWrapperFilter.docIdSetToCache by default?{quote}
The main reason is that there are circumstances under which skipTo() is faster on an OpenBitSet than on a SortedVIntList. OpenBitSet allows random access, so it can start the skip from any point, but SortedVIntList can only start the skip from its current position.
OTOH SortedVIntList does have the advantage of being smaller when the set is sparse, and this may bring garbage collection advantages.
In all, not completely convincing either way.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641973#action_12641973 ]
Michael McCandless commented on LUCENE-1296:
--------------------------------------------
I guess we should deprecate the finalResult methods in BooleanFilter & ChainedFilter, and suggest using CachingWrapperFilter instead?
Also, why not put your logic to sometimes choose a SortedVIntList impl into CachingWrapperFilter.docIdSetToCache by default?
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1296:
---------------------------------
Attachment: LUCENE-1296.patch
Adds a docIdSetToCache method to CachingWrapperFilter.
Removes the choice of a compact underlying data structure from contrib filters.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, LUCENE-1296.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Elschot updated LUCENE-1296:
---------------------------------
Attachment: LUCENE-1296b.patch
This time with finalResult() also removed from BooleanFilter.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, LUCENE-1296.patch, LUCENE-1296b.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1296) Allow use of compact DocIdSet in
CachingWrapperFilter
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic updated LUCENE-1296:
-------------------------------------
Lucene Fields: [New, Patch Available] (was: [Patch Available, New])
Fix Version/s: 2.9
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1296) Allow use of compact
DocIdSet in CachingWrapperFilter
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640832#action_12640832 ]
paul.elschot@xs4all.nl edited comment on LUCENE-1296 at 10/19/08 3:52 AM:
----------------------------------------------------------------
This didn't make it into 2.4.
A side effect of that is that SortedVIntList will sometimes be used instead of an OpenBitSet in contrib search/BooleanFilter and misc/ChainedFilter. So far no problems have surfaced there, which is good news. I wonder if there was any performance improvement in practice because of this.
was (Author: paul.elschot@xs4all.nl):
This didn't make it into 2.4.
A side effect of that is that SortedVIntList will somtimes be used instead of an OpenBitSet contrib search/BooleanFilter and misc/ChainedFilter. So far no problems have surfaced there, which is good news. I wonder if there was any performance improvement in practice because of this.
> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
> Key: LUCENE-1296
> URL: https://issues.apache.org/jira/browse/LUCENE-1296
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org