You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/09 08:30:55 UTC
[GitHub] [pulsar] eolivelli commented on a change in pull request #10918: [Build] Fix java-test-functions dependencies and packaging
eolivelli commented on a change in pull request #10918:
URL: https://github.com/apache/pulsar/pull/10918#discussion_r705108091
##########
File path: tests/docker-images/java-test-functions/pom.xml
##########
@@ -20,90 +20,82 @@
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
- <parent>
- <groupId>org.apache.pulsar.tests</groupId>
- <artifactId>docker-images</artifactId>
- <version>2.9.0-SNAPSHOT</version>
- </parent>
- <modelVersion>4.0.0</modelVersion>
- <artifactId>java-test-functions</artifactId>
- <name>Apache Pulsar :: Tests :: Docker Images :: Java Test Functions</name>
- <dependencies>
- <dependency>
- <groupId>org.apache.pulsar</groupId>
- <artifactId>pulsar-io-core</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.pulsar</groupId>
- <artifactId>pulsar-client</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.avro</groupId>
- <artifactId>avro</artifactId>
- <version>${avro.version}</version>
- </dependency>
-
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
- <version>${jackson.databind.version}</version>
- </dependency>
- </dependencies>
- <packaging>jar</packaging>
+ <parent>
+ <groupId>org.apache.pulsar.tests</groupId>
+ <artifactId>docker-images</artifactId>
+ <version>2.9.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>java-test-functions</artifactId>
+ <name>Apache Pulsar :: Tests :: Docker Images :: Java Test Functions</name>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.pulsar</groupId>
+ <artifactId>pulsar-io-core</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.pulsar</groupId>
+ <artifactId>pulsar-functions-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <!-- allow sinks to use native Avro and Json -->
+ <dependency>
+ <groupId>org.apache.avro</groupId>
Review comment:
this is not needed anymore, can you please drop this?
##########
File path: tests/docker-images/java-test-functions/pom.xml
##########
@@ -20,90 +20,82 @@
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
- <parent>
- <groupId>org.apache.pulsar.tests</groupId>
- <artifactId>docker-images</artifactId>
- <version>2.9.0-SNAPSHOT</version>
- </parent>
- <modelVersion>4.0.0</modelVersion>
- <artifactId>java-test-functions</artifactId>
- <name>Apache Pulsar :: Tests :: Docker Images :: Java Test Functions</name>
- <dependencies>
- <dependency>
- <groupId>org.apache.pulsar</groupId>
- <artifactId>pulsar-io-core</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.pulsar</groupId>
- <artifactId>pulsar-client</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.avro</groupId>
- <artifactId>avro</artifactId>
- <version>${avro.version}</version>
- </dependency>
-
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
- <version>${jackson.databind.version}</version>
- </dependency>
- </dependencies>
- <packaging>jar</packaging>
+ <parent>
+ <groupId>org.apache.pulsar.tests</groupId>
+ <artifactId>docker-images</artifactId>
+ <version>2.9.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>java-test-functions</artifactId>
+ <name>Apache Pulsar :: Tests :: Docker Images :: Java Test Functions</name>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.pulsar</groupId>
+ <artifactId>pulsar-io-core</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.pulsar</groupId>
+ <artifactId>pulsar-functions-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <!-- allow sinks to use native Avro and Json -->
+ <dependency>
+ <groupId>org.apache.avro</groupId>
+ <artifactId>avro</artifactId>
+ <version>${avro.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
Review comment:
this is not needed anymore, can you please drop this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org