[jira] [Commented] (METRON-1792) Simplify Profile Definitions in Integration Tests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642507#comment-16642507 ] 

ASF GitHub Bot commented on METRON-1792:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1211#discussion_r223501784
  
    --- Diff: metron-analytics/metron-profiler-storm/src/test/java/org/apache/metron/profiler/storm/integration/ConfigUploadComponent.java ---
    @@ -86,11 +90,17 @@ private void upload() throws Exception {
        * @param client The zookeeper client.
        */
       private void uploadProfilerConfig(CuratorFramework client) throws Exception {
    -    if (profilerConfiguration != null) {
    -      byte[] globalConfig = readProfilerConfigFromFile(profilerConfiguration);
    -      if (globalConfig.length > 0) {
    -        writeProfilerConfigToZookeeper(readProfilerConfigFromFile(profilerConfiguration), client);
    -      }
    +    byte[] configBytes = null;
    +
    +    if (profilerConfigurationPath != null) {
    +      configBytes = readProfilerConfigFromFile(profilerConfigurationPath);
    +
    +    } else if(profilerConfig != null) {
    --- End diff --
    
    I need the upload to happen based on either a path to a file or a String that was passed in.


> Simplify Profile Definitions in Integration Tests
> -------------------------------------------------
>
>                 Key: METRON-1792
>                 URL: https://issues.apache.org/jira/browse/METRON-1792
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>            Priority: Major
>
> It would be easier to read the ProfilerIntegrationTest if the profile definitions were defined 'inline' rather than in separate configuration files.  
>  
> This was feedback that was offered as part of another code review; https://github.com/apache/metron/pull/1174#discussion_r215456000



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)