You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2014/02/04 20:22:08 UTC
[jira] [Updated] (OAK-1387) Pass CommitInfo to commit hooks,
editors and validators
[ https://issues.apache.org/jira/browse/OAK-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated OAK-1387:
-------------------------------
Attachment: 0001-OAK-1387-Pass-CommitInfo-to-commit-hooks-editors-and.patch
Proposed patch.
> Pass CommitInfo to commit hooks, editors and validators
> -------------------------------------------------------
>
> Key: OAK-1387
> URL: https://issues.apache.org/jira/browse/OAK-1387
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: core
> Reporter: Jukka Zitting
> Attachments: 0001-OAK-1387-Pass-CommitInfo-to-commit-hooks-editors-and.patch
>
>
> In OAK-144 we introduced the {{CommitInfo}} object for observation purposes. It's passed along with custom commit hooks to the {{NodeStore.merge()}}.
> It turns out that the custom commit hooks coming from {{AbstractRoot.getCommitHook()}} are constructed using information that could well be passed through the {{CommitInfo}} object. This would simplify things as all hooks that apply to a commit could be accessed through the whiteboard as normal services.
> Doing this would require us to extend the amount of information that can be passed through the {{CommitInfo}} object, and adjust the {{CommitHook}}, {{EditorProvider}} and {{ValidatorProvider}} interfaces to accept also a {{CommitInfo}} argument. None of this seems too troublesome.
> WDYT?
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)