You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Joel Friedly <no...@github.com> on 2014/03/21 23:34:20 UTC
[jclouds] Remove Nova instance metadata limit (#324)
Rackspace cloud limits instance metadata to 5 key-value pairs, but
upstream Nova only sets the limit at 128 by default. This patch removes
the limit entirely; the official python clients don't check it and the
server is responsible for enforcing it anyway.
Fixes: https://issues.apache.org/jira/browse/JCLOUDS-507
You can merge this Pull Request by running:
git pull https://github.com/jfriedly/jclouds metadata-limits
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/324
-- Commit Summary --
* Remove Nova instance metadata limit
-- File Changes --
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/options/CreateServerOptions.java (5)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/324.patch
https://github.com/jclouds/jclouds/pull/324.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by Andrew Phillips <no...@github.com>.
Hm...looks like we didn't have a test to verify the limitation anyway ;-) +1 - looks good to me too.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38337083
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #682](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/682/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38335657
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by Andrew Phillips <no...@github.com>.
> Probably just 1.7.x if at all
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38340845
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by Zack Shoylev <no...@github.com>.
About to merge...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38336779
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #936](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/936/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38335445
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by Joel Friedly <no...@github.com>.
I don't really think it will make a big difference, but it's a trivial
backport, so sure. What versions would you like me to backport it to?
On Mar 21, 2014 5:36 PM, "Zack Shoylev" <no...@github.com> wrote:
> Also, should this be backported?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/324#issuecomment-38337970>
> .
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38338978
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by Zack Shoylev <no...@github.com>.
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38336676
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by Zack Shoylev <no...@github.com>.
Probably just 1.7.x if at all
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38339212
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by Zack Shoylev <no...@github.com>.
Also, should this be backported?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38337970
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by Zack Shoylev <no...@github.com>.
merged - good to close
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38337949
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1152](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1152/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38336067
Re: [jclouds] Remove Nova instance metadata limit (#324)
Posted by Joel Friedly <no...@github.com>.
Closed #324.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324