[jira] [Commented] (LUCENE-5559) Argument validation for TokenFilters having numeric constructor parameter(s)

["Ahmet Arslan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951194#comment-13951194 ] 

Ahmet Arslan commented on LUCENE-5559:
--------------------------------------

NGramTokenFilte, EdgeNGramTokenFilter, NGramTokenizer andEdgeNGramTokenizer have this check
{code}  
    if (minGram < 1) {
      throw new IllegalArgumentException("minGram must be greater than zero");
    }
    if (minGram > maxGram) {
      throw new IllegalArgumentException("minGram must not be greater than maxGram");
    }
{code}  

It is necessary to add checks to Factory classes too?

> Argument validation for TokenFilters having numeric constructor parameter(s)
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-5559
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5559
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.7
>            Reporter: Ahmet Arslan
>            Priority: Minor
>             Fix For: 4.8
>
>
> Some TokenFilters have numeric arguments in their constructors. They should throw {{IllegalArgumentException}} for negative or meaningless values. 
> Here is some examples that demonstrates invalid/meaningless arguments :
> {code:xml}
>  <filter class="solr.LimitTokenCountFilterFactory" maxTokenCount="-10" />
> {code}
> {code:xml}
>  <filter class="solr.LengthFilterFactory" min="-5" max="-1" />
> {code}
> {code:xml}
>  <filter class="solr.LimitTokenPositionFilterFactory" maxTokenPosition="-3" />
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org