You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2015/10/31 08:47:27 UTC

[jira] [Resolved] (REEF-894) GetBridgeInjector should not create a new Injector

     [ https://issues.apache.org/jira/browse/REEF-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun resolved REEF-894.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 0.14

Resolved via https://github.com/apache/incubator-reef/pull/604

> GetBridgeInjector should not create a new Injector
> --------------------------------------------------
>
>                 Key: REEF-894
>                 URL: https://issues.apache.org/jira/browse/REEF-894
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF.NET, REEF.NET Driver
>            Reporter: Andrew Chung
>            Assignee: Andrew Chung
>             Fix For: 0.14
>
>
> {{GetBridgeInjector}} in {{BridgeConfigurationProvider}} violates the singleton guarantee we have for our Driver by returning a new {{IInjector}} instantiated with a new {{BridgeConfiguration}} everytime we call it. We should make {{BridgeConfiguration}} and the {{IInjector}} retrieved from {{GetBridgeInjector}} lazy, static singletons instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)