You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by wgtmac <gi...@git.apache.org> on 2018/03/19 04:21:18 UTC

[GitHub] orc pull request #18: ORC-10. Correct bug when moving ORC files between time...

Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/18#discussion_r175328447
  
    --- Diff: c++/src/ColumnReader.cc ---
    @@ -327,7 +329,9 @@ namespace orc {
                 nanoBuffer[i] *= 10;
               }
             }
    -        secsBuffer[i] += epochOffset;
    +        int64_t writerTime = secsBuffer[i] + epochOffset;
    +        secsBuffer[i] = writerTime +
    --- End diff --
    
    @omalley I think here introduces an inconsistency between reader and writer. The secsBuffer[i] in the TimestampVectorBatch of reader side will not get same value on the java writer/reader side.


---