[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #16394: [Bug](datev2) Fix bug when cast datev2 to date

["carlvinhust2012 (via GitHub)" <gi...@apache.org>]

carlvinhust2012 commented on code in PR #16394:
URL: https://github.com/apache/doris/pull/16394#discussion_r1095434163


##########
be/src/vec/functions/function_cast.h:
##########
@@ -194,17 +194,16 @@ struct ConvertImpl {
                     } else if constexpr (IsTimeType<ToDataType>) {
                         if constexpr (IsDateTimeType<ToDataType> && IsDateV2Type<FromDataType>) {
                             DataTypeDateV2::cast_to_date_time(vec_from[i], vec_to[i]);
-                        } else if constexpr (IsDateTimeV2Type<ToDataType> &&
-                                             IsDateV2Type<FromDataType>) {
+                        } else if constexpr (IsDateType<ToDataType> && IsDateV2Type<FromDataType>) {

Review Comment:
   so here is check the cast from 'DateV2Type' to 'DateType'?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org