[GitHub] [camel-quarkus] gnodet edited a comment on issue #371: Issue 337

[GitBox <gi...@apache.org>]

gnodet edited a comment on issue #371: Issue 337
URL: https://github.com/apache/camel-quarkus/pull/371#issuecomment-549793423
 
 
   > -1 for the last commit `examples should import the BOM instead of inheriting it as users would do`
   > 
   > The previous setup was intentional to keep apart the plugin config we need for our build from the config the end users need for their builds. With the original setup it was much easy to copy an example out of our source tree and use it as a base for the user's real world project. The user guide is broken now.
   
   @ppalaga I would challenge the fact that it's easier to copy from the previous setup.  The only difference is that we would now have to remove the parent instead of removing the relative path.  That's not much a difference.
   The benefit is that the examples do now inherit from the "global" settings (autoformatting, legal files, ...), else we'd have to add a bunch of plugins definitions to each example, or simply have them not complying with the rest of the build.
   Also, I really think that the correct way of using BOMs is to import them, not to create a child project.
   I can edit the user guide to reflect the new setup if you agree.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services