You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2010/04/29 19:25:33 UTC

svn commit: r939392 - in /james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty: ChannelAttributeSupport.java LineHandlerUpstreamHandler.java TimeoutHandler.java

Author: norman
Date: Thu Apr 29 17:25:32 2010
New Revision: 939392

URL: http://svn.apache.org/viewvc?rev=939392&view=rev
Log:
just some javadocs

Modified:
    james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/ChannelAttributeSupport.java
    james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/LineHandlerUpstreamHandler.java
    james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/TimeoutHandler.java

Modified: james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/ChannelAttributeSupport.java
URL: http://svn.apache.org/viewvc/james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/ChannelAttributeSupport.java?rev=939392&r1=939391&r2=939392&view=diff
==============================================================================
--- james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/ChannelAttributeSupport.java (original)
+++ james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/ChannelAttributeSupport.java Thu Apr 29 17:25:32 2010
@@ -21,6 +21,12 @@ package org.apache.james.socket.netty;
 import org.jboss.netty.channel.Channel;
 import org.jboss.netty.channel.ChannelLocal;
 
+/**
+ * This interface should be implemented by handlers which need to store attachements that 
+ * are shared across all handlers
+ * 
+ *
+ */
 public interface ChannelAttributeSupport {
 
     /**

Modified: james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/LineHandlerUpstreamHandler.java
URL: http://svn.apache.org/viewvc/james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/LineHandlerUpstreamHandler.java?rev=939392&r1=939391&r2=939392&view=diff
==============================================================================
--- james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/LineHandlerUpstreamHandler.java (original)
+++ james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/LineHandlerUpstreamHandler.java Thu Apr 29 17:25:32 2010
@@ -32,10 +32,11 @@ import org.jboss.netty.channel.SimpleCha
  *
  * @param <Session>
  */
-@ChannelPipelineCoverage("one")
+@ChannelPipelineCoverage("all")
 public class LineHandlerUpstreamHandler<Session extends ProtocolSession> extends SimpleChannelUpstreamHandler implements ChannelAttributeSupport{
 
     private LineHandler<Session> handler;
+    
     public LineHandlerUpstreamHandler(LineHandler<Session> handler) {
         this.handler = handler;
     }

Modified: james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/TimeoutHandler.java
URL: http://svn.apache.org/viewvc/james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/TimeoutHandler.java?rev=939392&r1=939391&r2=939392&view=diff
==============================================================================
--- james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/TimeoutHandler.java (original)
+++ james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/netty/TimeoutHandler.java Thu Apr 29 17:25:32 2010
@@ -18,11 +18,17 @@
  ****************************************************************/
 package org.apache.james.socket.netty;
 
+import org.jboss.netty.channel.Channel;
 import org.jboss.netty.channel.ChannelHandlerContext;
 import org.jboss.netty.handler.timeout.IdleState;
 import org.jboss.netty.handler.timeout.IdleStateHandler;
 import org.jboss.netty.util.Timer;
 
+/**
+ * {@link IdleStateHandler} implementation which disconnect the {@link Channel} after a configured
+ * idle timeout
+ *
+ */
 public class TimeoutHandler extends IdleStateHandler{
 
     public TimeoutHandler(Timer timer, int readerIdleTimeSeconds, int writerIdleTimeSeconds, int allIdleTimeSeconds) {



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org