You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/24 16:25:31 UTC

[GitHub] [beam] ricardolui opened a new pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

ricardolui opened a new pull request #12672:
URL: https://github.com/apache/beam/pull/12672


   Adding MySQL connector lib to dependencies, so it can be used with external JDBC.
   This is for cross language support on python and so it gets added on beam-sdks-java-io-expansion-service*.jar
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [X ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website | Whitespace
   --- | --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/be
 am_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   ![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg)
   ![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg)
   ![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12672:
URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report
   > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) (e8ea2a3) into [master](https://codecov.io/gh/apache/beam/commit/c815e8e5e2f6d5127c447b8fb6f77b0c30f02d9c?el=desc) (c815e8e) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12672/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12672   +/-   ##
   =======================================
     Coverage   34.34%   34.34%           
   =======================================
     Files         692      692           
     Lines       81961    81948   -13     
     Branches     9265     9263    -2     
   =======================================
   - Hits        28147    28144    -3     
   + Misses      53391    53381   -10     
     Partials      423      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-aW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `26.83% <0.00%> (-0.07%)` | :arrow_down: |
   | [io/gcp/bigquery\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-aW8vZ2NwL2JpZ3F1ZXJ5X3Rlc3QucHk=) | `27.56% <0.00%> (+0.17%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=footer). Last update [094d06c...e8ea2a3](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] stale[bot] commented on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #12672:
URL: https://github.com/apache/beam/pull/12672#issuecomment-723500401


   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] stale[bot] commented on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #12672:
URL: https://github.com/apache/beam/pull/12672#issuecomment-727715815


   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12672:
URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report
   > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12672/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12672      +/-   ##
   ==========================================
   - Coverage   34.47%   34.34%   -0.13%     
   ==========================================
     Files         684      692       +8     
     Lines       81483    81948     +465     
     Branches     9180     9263      +83     
   ==========================================
   + Hits        28090    28144      +54     
   - Misses      52965    53381     +416     
   + Partials      428      423       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [typehints/typecheck\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVja190ZXN0X3B5My5weQ==) | `31.54% <0.00%> (-16.00%)` | :arrow_down: |
   | [typehints/typecheck.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVjay5weQ==) | `29.44% <0.00%> (-6.18%)` | :arrow_down: |
   | [utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `30.95% <0.00%> (-2.39%)` | :arrow_down: |
   | [runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==) | `33.81% <0.00%> (-0.87%)` | :arrow_down: |
   | [pipeline.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.04% <0.00%> (-0.28%)` | :arrow_down: |
   | [options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-b3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `52.99% <0.00%> (-0.16%)` | :arrow_down: |
   | [transforms/ptransform\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9wdHJhbnNmb3JtX3Rlc3QucHk=) | `18.37% <0.00%> (-0.09%)` | :arrow_down: |
   | [transforms/core.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9jb3JlLnB5) | `36.79% <0.00%> (-0.05%)` | :arrow_down: |
   | [runners/common.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy9jb21tb24ucHk=) | `27.50% <0.00%> (ø)` | |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | ... and [29 more](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=footer). Last update [094d06c...e8ea2a3](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12672:
URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report
   > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12672/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12672      +/-   ##
   ==========================================
   - Coverage   34.47%   34.34%   -0.13%     
   ==========================================
     Files         684      692       +8     
     Lines       81483    81948     +465     
     Branches     9180     9263      +83     
   ==========================================
   + Hits        28090    28144      +54     
   - Misses      52965    53381     +416     
   + Partials      428      423       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [typehints/typecheck\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVja190ZXN0X3B5My5weQ==) | `31.54% <0.00%> (-16.00%)` | :arrow_down: |
   | [typehints/typecheck.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVjay5weQ==) | `29.44% <0.00%> (-6.18%)` | :arrow_down: |
   | [utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `30.95% <0.00%> (-2.39%)` | :arrow_down: |
   | [runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==) | `33.81% <0.00%> (-0.87%)` | :arrow_down: |
   | [pipeline.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.04% <0.00%> (-0.28%)` | :arrow_down: |
   | [options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-b3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `52.99% <0.00%> (-0.16%)` | :arrow_down: |
   | [transforms/ptransform\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9wdHJhbnNmb3JtX3Rlc3QucHk=) | `18.37% <0.00%> (-0.09%)` | :arrow_down: |
   | [transforms/core.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9jb3JlLnB5) | `36.79% <0.00%> (-0.05%)` | :arrow_down: |
   | [runners/common.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy9jb21tb24ucHk=) | `27.50% <0.00%> (ø)` | |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | ... and [29 more](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=footer). Last update [094d06c...e8ea2a3](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] stale[bot] closed pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #12672:
URL: https://github.com/apache/beam/pull/12672


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12672:
URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report
   > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12672/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12672      +/-   ##
   ==========================================
   - Coverage   34.47%   34.34%   -0.13%     
   ==========================================
     Files         684      692       +8     
     Lines       81483    81948     +465     
     Branches     9180     9263      +83     
   ==========================================
   + Hits        28090    28144      +54     
   - Misses      52965    53381     +416     
   + Partials      428      423       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [typehints/typecheck\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVja190ZXN0X3B5My5weQ==) | `31.54% <0.00%> (-16.00%)` | :arrow_down: |
   | [typehints/typecheck.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVjay5weQ==) | `29.44% <0.00%> (-6.18%)` | :arrow_down: |
   | [utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `30.95% <0.00%> (-2.39%)` | :arrow_down: |
   | [runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==) | `33.81% <0.00%> (-0.87%)` | :arrow_down: |
   | [pipeline.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.04% <0.00%> (-0.28%)` | :arrow_down: |
   | [options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-b3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `52.99% <0.00%> (-0.16%)` | :arrow_down: |
   | [transforms/ptransform\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9wdHJhbnNmb3JtX3Rlc3QucHk=) | `18.37% <0.00%> (-0.09%)` | :arrow_down: |
   | [transforms/core.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9jb3JlLnB5) | `36.79% <0.00%> (-0.05%)` | :arrow_down: |
   | [runners/common.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy9jb21tb24ucHk=) | `27.50% <0.00%> (ø)` | |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | ... and [29 more](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=footer). Last update [094d06c...e8ea2a3](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12672:
URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report
   > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) (e8ea2a3) into [master](https://codecov.io/gh/apache/beam/commit/c815e8e5e2f6d5127c447b8fb6f77b0c30f02d9c?el=desc) (c815e8e) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12672/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12672   +/-   ##
   =======================================
     Coverage   34.34%   34.34%           
   =======================================
     Files         692      692           
     Lines       81961    81948   -13     
     Branches     9265     9263    -2     
   =======================================
   - Hits        28147    28144    -3     
   + Misses      53391    53381   -10     
     Partials      423      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-aW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `26.83% <0.00%> (-0.07%)` | :arrow_down: |
   | [io/gcp/bigquery\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-aW8vZ2NwL2JpZ3F1ZXJ5X3Rlc3QucHk=) | `27.56% <0.00%> (+0.17%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=footer). Last update [094d06c...e8ea2a3](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12672:
URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report
   > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12672/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12672      +/-   ##
   ==========================================
   - Coverage   34.47%   34.34%   -0.13%     
   ==========================================
     Files         684      692       +8     
     Lines       81483    81948     +465     
     Branches     9180     9263      +83     
   ==========================================
   + Hits        28090    28144      +54     
   - Misses      52965    53381     +416     
   + Partials      428      423       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [typehints/typecheck\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVja190ZXN0X3B5My5weQ==) | `31.54% <0.00%> (-16.00%)` | :arrow_down: |
   | [typehints/typecheck.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVjay5weQ==) | `29.44% <0.00%> (-6.18%)` | :arrow_down: |
   | [utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `30.95% <0.00%> (-2.39%)` | :arrow_down: |
   | [runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==) | `33.81% <0.00%> (-0.87%)` | :arrow_down: |
   | [pipeline.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.04% <0.00%> (-0.28%)` | :arrow_down: |
   | [options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-b3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `52.99% <0.00%> (-0.16%)` | :arrow_down: |
   | [transforms/ptransform\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9wdHJhbnNmb3JtX3Rlc3QucHk=) | `18.37% <0.00%> (-0.09%)` | :arrow_down: |
   | [transforms/core.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9jb3JlLnB5) | `36.79% <0.00%> (-0.05%)` | :arrow_down: |
   | [runners/common.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy9jb21tb24ucHk=) | `27.50% <0.00%> (ø)` | |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | ... and [29 more](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=footer). Last update [094d06c...e8ea2a3](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12672:
URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report
   > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12672/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12672      +/-   ##
   ==========================================
   - Coverage   34.47%   34.34%   -0.13%     
   ==========================================
     Files         684      692       +8     
     Lines       81483    81948     +465     
     Branches     9180     9263      +83     
   ==========================================
   + Hits        28090    28144      +54     
   - Misses      52965    53381     +416     
   + Partials      428      423       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [typehints/typecheck\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVja190ZXN0X3B5My5weQ==) | `31.54% <0.00%> (-16.00%)` | :arrow_down: |
   | [typehints/typecheck.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVjay5weQ==) | `29.44% <0.00%> (-6.18%)` | :arrow_down: |
   | [utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `30.95% <0.00%> (-2.39%)` | :arrow_down: |
   | [runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==) | `33.81% <0.00%> (-0.87%)` | :arrow_down: |
   | [pipeline.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.04% <0.00%> (-0.28%)` | :arrow_down: |
   | [options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-b3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `52.99% <0.00%> (-0.16%)` | :arrow_down: |
   | [transforms/ptransform\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9wdHJhbnNmb3JtX3Rlc3QucHk=) | `18.37% <0.00%> (-0.09%)` | :arrow_down: |
   | [transforms/core.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9jb3JlLnB5) | `36.79% <0.00%> (-0.05%)` | :arrow_down: |
   | [runners/common.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-cnVubmVycy9jb21tb24ucHk=) | `27.50% <0.00%> (ø)` | |
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | ... and [29 more](https://codecov.io/gh/apache/beam/pull/12672/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=footer). Last update [094d06c...e8ea2a3](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org