You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/04 14:16:46 UTC
[GitHub] [calcite] xy2953396112 opened a new pull request #1960: [CALCITE-3971] Support Calc in RelMdColumnOrigins
xy2953396112 opened a new pull request #1960:
URL: https://github.com/apache/calcite/pull/1960
https://issues.apache.org/jira/browse/CALCITE-3971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on a change in pull request #1960: [CALCITE-3971] Support Calc in RelMdColumnOrigins
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #1960:
URL: https://github.com/apache/calcite/pull/1960#discussion_r419509945
##########
File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnOrigins.java
##########
@@ -253,4 +264,24 @@ public Void visitInputRef(RexInputRef inputRef) {
}
return set;
}
+
+ private Set<RelColumnOrigin> getMultipleColumns(RexNode rexNode, RelNode input,
+ final RelMetadataQuery mq) {
+ // Anything else is a derivation, possibly from multiple
+ // columns.
Review comment:
> This comment should be added in the caller of this method.
Thanks, update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hsyuan commented on a change in pull request #1960: [CALCITE-3971] Support Calc in RelMdColumnOrigins
Posted by GitBox <gi...@apache.org>.
hsyuan commented on a change in pull request #1960:
URL: https://github.com/apache/calcite/pull/1960#discussion_r419496288
##########
File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnOrigins.java
##########
@@ -253,4 +264,24 @@ public Void visitInputRef(RexInputRef inputRef) {
}
return set;
}
+
+ private Set<RelColumnOrigin> getMultipleColumns(RexNode rexNode, RelNode input,
+ final RelMetadataQuery mq) {
+ // Anything else is a derivation, possibly from multiple
+ // columns.
Review comment:
This comment should be added in the caller of this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org