You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/12 09:01:58 UTC

[GitHub] [activemq-artemis] martin-g opened a new pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

martin-g opened a new pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180


   1) Update Netty to 4.1.50 that includes aarch64 binaries
   
   2) Use Maven wrapper
   
   This way it will use the preferred version of Maven.
   Also it seems Maven is not coming pre-installed on ARM64
   
   3) Update netty-tcnative to 2.0.31.Final
   
   4) Update Maven to 3.6.2 because artemis-console fails with 3.3.9
   
   5) travis_wait the build of 'examples'
   
   because it takes more time and Travis kills it: https://travis-ci.org/github/martin-g/activemq-artemis/jobs/697514020
   
   "The job exceeded the maximum time limit for jobs, and has been terminated."


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] martin-g commented on a change in pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#discussion_r441414758



##########
File path: .travis.yml
##########
@@ -12,9 +15,9 @@ before_install:
 # By setting anything to org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED we are disabling libaio loading on the testsuite
 script: 
 - set -e
-- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
+- ./mvnw -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Dnetty-transport-native-epoll-classifier=linux-`uname -m` -Pfast-tests -Pextra-tests -Ptests-CI -B install -q

Review comment:
       There is no `mvn` pre-installed on ARM64 VMs at TravisCI




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] martin-g commented on pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#issuecomment-645267271


   > can you rebase it?
   
   Rebased!
    
   > What is the point of testing the new platform? there are no natives in the testsuite for travis (we disable libaio on travis).
   
   Should I close this PR ?
   May end goal is to make
   `./modules/system/layers/base/org/apache/activemq/artemis/journal/main/lib/linux-x86_64/libartemis-native-64.so` available for `aarch64` too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#discussion_r441365561



##########
File path: .travis.yml
##########
@@ -12,9 +15,9 @@ before_install:
 # By setting anything to org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED we are disabling libaio loading on the testsuite
 script: 
 - set -e
-- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
+- ./mvnw -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Dnetty-transport-native-epoll-classifier=linux-`uname -m` -Pfast-tests -Pextra-tests -Ptests-CI -B install -q

Review comment:
       Can we keep this as plain mvn no need for mvnw




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] martin-g commented on pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#issuecomment-645361806


   https://github.com/apache/activemq-artemis-native/pull/8


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#issuecomment-645346034


   like, I don't have access an aarch64 box so i could build.
   
   Again, someone willing to use it, can just compile it themselves in 10 seconds.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] emiliofernandes commented on a change in pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
emiliofernandes commented on a change in pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#discussion_r441413956



##########
File path: .travis.yml
##########
@@ -12,9 +15,9 @@ before_install:
 # By setting anything to org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED we are disabling libaio loading on the testsuite
 script: 
 - set -e
-- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
+- ./mvnw -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Dnetty-transport-native-epoll-classifier=linux-`uname -m` -Pfast-tests -Pextra-tests -Ptests-CI -B install -q

Review comment:
       There is no `mvn` pre-installed on the ARM64 VMs at TravisCI.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] emiliofernandes commented on pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
emiliofernandes commented on pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#issuecomment-645265551


   > can you rebase it?
   
   Rebased!
   
   > What is the point of testing the new platform? there are no natives in the testsuite for travis (we disable libaio on travis).
   
   In that case maybe there is no point in testing on arm64.
   Should I close this PR or enable libaio just on arm64 ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] emiliofernandes removed a comment on pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
emiliofernandes removed a comment on pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#issuecomment-645265551


   > can you rebase it?
   
   Rebased!
   
   > What is the point of testing the new platform? there are no natives in the testsuite for travis (we disable libaio on travis).
   
   In that case maybe there is no point in testing on arm64.
   Should I close this PR or enable libaio just on arm64 ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#issuecomment-645345739


   @martin-g you should probably close this then, as we don't test the .so on travis. (environment issues on travis were killing us, so we disabled it).
   
   
   The issue really is how to build it?
   
   
   Someone willing to use artemis-native on aarch64 should do the cmake .; make and place the natives in the right place.
   
   Now if you have a way we can release with aarch64, you can probably look at the compilations scripts on artemis-native if you can come up with a way to do it in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] martin-g commented on pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#issuecomment-645347577


   > The issue really is how to build it?
   
   No. Custom build is easy.
   The idea is to provide the aarch64 binary within the Wildfly distribution.
   I will see what I can do!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic closed pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
clebertsuconic closed pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3180: ARTEMIS-2705 Test Artemis on aarch64 CPU architecture

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3180:
URL: https://github.com/apache/activemq-artemis/pull/3180#issuecomment-644963321


   can you rebase it?
   
   
   What is the point of testing the new platform? there are no natives in the testsuite for travis (we disable libaio on travis).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org