You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/17 17:10:13 UTC
[GitHub] [spark] yaooqinn opened a new pull request #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
yaooqinn opened a new pull request #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
The meaning of 'u' was day number of the week in SimpleDateFormat, it was changed to year in DateTimeFormatter. So we keep the old meaning of 'u' by substituting 'u' to 'e' internally and use DateTimeFormatter to parse the pattern string. In DateTimeFormatter, the 'e' and 'c' also represents day-of-week, we should mark them as illegal pattern character to stay the same as before.
This pr move the method `convertIncompatiblePattern` from `DatetimeUtils` to `DateTimeFormatterHelper` object, since it is quite specific for `DateTimeFormatterHelper` class.
And 'e' and 'c' char checking in this method.
besides `convertIncompatiblePattern` has a bug that will lose the last `'` if it ends with it, this pr fixes this too.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
avoid vagueness
bug fix
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no, these are not exposed yet
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add ut
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600402167
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24683/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600314227
**[Test build #119942 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119942/testReport)** for PR 27939 at commit [`5bb6497`](https://github.com/apache/spark/commit/5bb6497e2b9170fc487d3a91920acfea11588cbd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#discussion_r394084462
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -100,3 +100,10 @@ select to_timestamp("12.12342019-10-06S10:11", "ss.SSSSyyyy-MM-dd'S'HH:mm");
select to_timestamp("12.1232019-10-06S10:11", "ss.SSSSyyyy-MM-dd'S'HH:mm");
select to_timestamp("12.1232019-10-06S10:11", "ss.SSSSyy-MM-dd'S'HH:mm");
select to_timestamp("12.1234019-10-06S10:11", "ss.SSSSy-MM-dd'S'HH:mm");
+
+select to_timestamp("2019-10-06S", "yyyy-MM-dd'S'");
+select to_timestamp("S2019-10-06", "'S'yyyy-MM-dd");
+
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd eeee');
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd cccc');
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd uuuu');
Review comment:
we can add a test of `uuee` to demonstrate the problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458661
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119961/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458830
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600315074
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600193958
**[Test build #119942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119942/testReport)** for PR 27939 at commit [`5bb6497`](https://github.com/apache/spark/commit/5bb6497e2b9170fc487d3a91920acfea11588cbd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600194637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24665/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600422777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24689/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600407160
**[Test build #119961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119961/testReport)** for PR 27939 at commit [`2d0c649`](https://github.com/apache/spark/commit/2d0c649a5f609aa5d1aaa943d7a723e4e5b33cd2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458375
**[Test build #119961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119961/testReport)** for PR 27939 at commit [`2d0c649`](https://github.com/apache/spark/commit/2d0c649a5f609aa5d1aaa943d7a723e4e5b33cd2).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458693
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119965/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600407442
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600401812
**[Test build #119960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119960/testReport)** for PR 27939 at commit [`f759596`](https://github.com/apache/spark/commit/f759596bc6119e6fa6690642feb36ea85d1a00d0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600192226
cc @cloud-fan @maropu @MaxGekk @xuanyuanking @dongjoon-hyun thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600315081
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119942/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600407447
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24684/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600574783
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-601504123
Late LGTM, thanks for the fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600465020
**[Test build #119973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119973/testReport)** for PR 27939 at commit [`572759e`](https://github.com/apache/spark/commit/572759e631fb6da702c4695c3b8d7cd1e29add60).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600194629
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600422773
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#discussion_r394084585
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -100,3 +100,10 @@ select to_timestamp("12.12342019-10-06S10:11", "ss.SSSSyyyy-MM-dd'S'HH:mm");
select to_timestamp("12.1232019-10-06S10:11", "ss.SSSSyyyy-MM-dd'S'HH:mm");
select to_timestamp("12.1232019-10-06S10:11", "ss.SSSSyy-MM-dd'S'HH:mm");
select to_timestamp("12.1234019-10-06S10:11", "ss.SSSSy-MM-dd'S'HH:mm");
+
+select to_timestamp("2019-10-06S", "yyyy-MM-dd'S'");
+select to_timestamp("S2019-10-06", "'S'yyyy-MM-dd");
+
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd eeee');
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd cccc');
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd uuuu');
Review comment:
We should also highlight this problem in PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600422437
**[Test build #119965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119965/testReport)** for PR 27939 at commit [`572759e`](https://github.com/apache/spark/commit/572759e631fb6da702c4695c3b8d7cd1e29add60).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600422437
**[Test build #119965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119965/testReport)** for PR 27939 at commit [`572759e`](https://github.com/apache/spark/commit/572759e631fb6da702c4695c3b8d7cd1e29add60).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458693
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119965/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458377
**[Test build #119960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119960/testReport)** for PR 27939 at commit [`f759596`](https://github.com/apache/spark/commit/f759596bc6119e6fa6690642feb36ea85d1a00d0).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600402160
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#discussion_r394100327
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -116,7 +116,8 @@ private object DateTimeFormatterHelper {
def createBuilderWithVarLengthSecondFraction(
pattern: String): DateTimeFormatterBuilder = {
val builder = createBuilder()
- pattern.split("'").zipWithIndex.foreach {
+ val patternSplits = pattern.split("'")
Review comment:
unnecessary change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458661
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119961/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600315081
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119942/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600422777
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24689/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600407442
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600574787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119973/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600574038
**[Test build #119973 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119973/testReport)** for PR 27939 at commit [`572759e`](https://github.com/apache/spark/commit/572759e631fb6da702c4695c3b8d7cd1e29add60).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600465448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24696/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600574787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119973/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458830
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458380
**[Test build #119965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119965/testReport)** for PR 27939 at commit [`572759e`](https://github.com/apache/spark/commit/572759e631fb6da702c4695c3b8d7cd1e29add60).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600194637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24665/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600402160
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458685
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600574783
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600590382
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600401812
**[Test build #119960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119960/testReport)** for PR 27939 at commit [`f759596`](https://github.com/apache/spark/commit/f759596bc6119e6fa6690642feb36ea85d1a00d0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600193958
**[Test build #119942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119942/testReport)** for PR 27939 at commit [`5bb6497`](https://github.com/apache/spark/commit/5bb6497e2b9170fc487d3a91920acfea11588cbd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458837
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119960/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458837
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119960/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600462684
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600465020
**[Test build #119973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119973/testReport)** for PR 27939 at commit [`572759e`](https://github.com/apache/spark/commit/572759e631fb6da702c4695c3b8d7cd1e29add60).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600402167
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24683/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458685
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600422773
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600407160
**[Test build #119961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119961/testReport)** for PR 27939 at commit [`2d0c649`](https://github.com/apache/spark/commit/2d0c649a5f609aa5d1aaa943d7a723e4e5b33cd2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600465448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24696/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#discussion_r394088097
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -100,3 +100,10 @@ select to_timestamp("12.12342019-10-06S10:11", "ss.SSSSyyyy-MM-dd'S'HH:mm");
select to_timestamp("12.1232019-10-06S10:11", "ss.SSSSyyyy-MM-dd'S'HH:mm");
select to_timestamp("12.1232019-10-06S10:11", "ss.SSSSyy-MM-dd'S'HH:mm");
select to_timestamp("12.1234019-10-06S10:11", "ss.SSSSy-MM-dd'S'HH:mm");
+
+select to_timestamp("2019-10-06S", "yyyy-MM-dd'S'");
+select to_timestamp("S2019-10-06", "'S'yyyy-MM-dd");
+
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd eeee');
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd cccc');
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd uuuu');
Review comment:
updated. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600465437
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600465437
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458649
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600194629
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600458649
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#discussion_r394105751
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -116,7 +116,8 @@ private object DateTimeFormatterHelper {
def createBuilderWithVarLengthSecondFraction(
pattern: String): DateTimeFormatterBuilder = {
val builder = createBuilder()
- pattern.split("'").zipWithIndex.foreach {
+ val patternSplits = pattern.split("'")
Review comment:
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27939:
[SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600407447
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24684/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27939: [SPARK-31176][SQL]
Remove support for 'e'/'c' as datetime pattern charactar
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#issuecomment-600315074
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org