You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Michelle Caisse (JIRA)" <ji...@apache.org> on 2006/12/08 21:34:24 UTC
[jira] Created: (JDO-444) Add public constructor for JDOHelper
Add public constructor for JDOHelper
------------------------------------
Key: JDO-444
URL: http://issues.apache.org/jira/browse/JDO-444
Project: JDO
Issue Type: New Feature
Components: api2, api2-legacy
Reporter: Michelle Caisse
Assigned To: Craig Russell
In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=all ]
Craig Russell updated JDO-444:
------------------------------
Attachment: JDOHelper-constructor.patch
Please review this patch.
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Attachments: JDOHelper-constructor.patch
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-444) Add public constructor for JDOHelper
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=comments#action_12459713 ]
Michael Bouschen commented on JDO-444:
--------------------------------------
The patch JDOHelper.diff looks good!
Just one comment: how about adding a comment to the test methods testConstructor and testGetInstance saying that the purpose of the test is calling the JDOHelper methods on the instance and making sure they do not throw an exception.
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, specification, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper.diff
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=all ]
Craig Russell updated JDO-444:
------------------------------
Component/s: specification
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, specification, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-constructor.patch
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=comments#action_12457421 ]
Craig Russell commented on JDO-444:
-----------------------------------
Add to the specification text:
The instance returned by the constructor is thread safe. It can be used from any number of threads without concern for synchronization.
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, api2-legacy, specification
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-constructor.patch
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=all ]
Craig Russell updated JDO-444:
------------------------------
Fix Version/s: JDO 2 maintenance release 1
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-constructor.patch
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=all ]
Craig Russell updated JDO-444:
------------------------------
Attachment: (was: JDOHelper.diff)
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, specification, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-patch.txt
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=all ]
Craig Russell updated JDO-444:
------------------------------
Attachment: JDOHelper-patch.txt
Thanks for the review.
I've added javadoc and @since 2.1 to the two classes. I think it's done.
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, specification, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-patch.txt
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-444) Add public constructor for JDOHelper
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=comments#action_12459746 ]
Michael Bouschen commented on JDO-444:
--------------------------------------
Looks good!
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, specification, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-patch.txt
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=all ]
Craig Russell updated JDO-444:
------------------------------
Attachment: (was: JDOHelper-constructor.patch)
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, specification, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper.diff
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JDO-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Russell resolved JDO-444.
-------------------------------
Resolution: Fixed
svn commit -m "JDO-444 Added public constructor and getInstance method to JDOHelper" api20/src/java/javax/jdo/JDOHelper.java
Sending api20/src/java/javax/jdo/JDOHelper.java
Transmitting file data .
Committed revision 509807.
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: https://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, api2-legacy, specification
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-patch.txt
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=comments#action_12457154 ]
Craig Russell commented on JDO-444:
-----------------------------------
Here is the spec update for review.
package javax.jdo;
class JDOHelper {
/* Some applications might prefer to use an instance
* method instead of static methods.
*/
public JDOHelper();
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-constructor.patch
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-444) Add public constructor for JDOHelper
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=comments#action_12457430 ]
Michael Bouschen commented on JDO-444:
--------------------------------------
The patch and the spec updates look good. Just one comment: above you added the javadoc for the spec update. I propose to use the same javadoc in the implementation in api2 and api2-legacy.
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, api2-legacy, specification
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-constructor.patch
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-444) Add public constructor for JDOHelper
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-444?page=all ]
Craig Russell updated JDO-444:
------------------------------
Attachment: JDOHelper.diff
Please review this patch. I've incorporated the getInstance change and added Javadoc.
> Add public constructor for JDOHelper
> ------------------------------------
>
> Key: JDO-444
> URL: http://issues.apache.org/jira/browse/JDO-444
> Project: JDO
> Issue Type: New Feature
> Components: api2, specification, api2-legacy
> Reporter: Michelle Caisse
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDOHelper-constructor.patch, JDOHelper.diff
>
>
> In Chapter 8, add after class JDOHelper {public JDOHelper(); For some usage patterns, an instance of JDOHelper on which to invoke methods is preferable to the use of static methods. For this purpose, a public constructor is provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira