You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jeroenv <gi...@git.apache.org> on 2015/10/26 10:06:27 UTC
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
GitHub user jeroenv opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107
getCookies bugfix
getCookies method should check if the CookieManager instance isn't null before calling getCookie method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeroenv/cordova-plugin-file-transfer getCookies_bugfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit 34ef3e5dbc913b09a03c802267eefaa6640f505f
Author: Jeroen Verhoest <je...@cheqroom.com>
Date: 2015-10-26T09:02:37Z
Added extra check for CookieManager instance (null pointer on Crosswalk/Android < 4.4)
commit 30e98878e35699609fa247976d70f01991fde53a
Author: Jeroen Verhoest <je...@cheqroom.com>
Date: 2015-10-26T09:04:10Z
Update plugin id and version for PGB
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-151242639
@jeroenv, thanks for your contribution!
Could you please file a [Jira bug](https://issues.apache.org/jira/browse/CB) with the issue details and environment?
The commits then should be squashed into a single one having CB-XXXX prefix.
Please also sign the ICLA so that your code could be pulled in: http://www.apache.org/dev/new-committers-guide.html#cla
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153290832
It does not reproduce on Android 4.0.3 device for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153275170
@jeroenv, I've tested `upload` with CrossWalk webview and have not found any issues.
Is there any additional details on how this issue could be reproduced?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#discussion_r42970796
--- Diff: plugin.xml ---
@@ -20,8 +20,8 @@
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
- id="cordova-plugin-file-transfer"
- version="1.3.1-dev">
+ id="checkroom-plugin-file-transfer"
--- End diff --
Looks like there are extra unrelated things in the PR, please remove them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by jeroenv <gi...@git.apache.org>.
Github user jeroenv commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-151550349
@daserge added the Jira bug: https://issues.apache.org/jira/browse/CB-9879
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-157075831
@jeroenv, I could not reproduce this on 4.0.3 device with DropBox as well; the repro steps I tried were the following:
* Using camera plugin manual tests with cordova-plugin-test-framework and csp-include.js from mobilespec,
* sourceType: PhotoLibary/SavedPhotoAlbum,
* mediaType: AllMedia (to show apps including DropBox providing images),
* Get picture -> select DropBox,
* Selected file path is in the following format: `file:///mnt/sdcard/Android/data/com.dropbox.android/files/u*******/scratch/file_name.jpg`
* Actions -> Upload image -> Upload complete
I've also tried to test on 4.1.2 emulator but the app does not run on it because of some CrossWalk issues: could not read AndroidManifest.xml on x86, and this error on arm:
`E/chromium( 2002): [ERROR:xwalk_platform_notification_service.cc(103)] Not implemented reached in virtual bool xwalk::XWalkPlatformNotificationService::GetDisplayedPersistentNotifications(content::BrowserContext*, std::set<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >*)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by Jesse <pu...@gmail.com>.
Post a picture that fails so we can verify.
> On Nov 3, 2015, at 3:30 AM, jeroenv <gi...@git.apache.org> wrote:
>
> Github user jeroenv commented on the pull request:
>
> https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153325389
>
> @daserge I forgot to mention that this bug only seems to happen with certain pictures you try to upload from Gallery/Dropbox/Google Drive. If you pick a picture from Photos or take a new picture and upload it everything works fine.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by jeroenv <gi...@git.apache.org>.
Github user jeroenv commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153325389
@daserge I forgot to mention that this bug only seems to happen with certain pictures you try to upload from Gallery/Dropbox/Google Drive. If you pick a picture from Photos or take a new picture and upload it everything works fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by jeroenv <gi...@git.apache.org>.
Github user jeroenv commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153284532
@daserge You can reproduce the error on an Android device (4.1.2 or smaller) and use CrossWalk webview together with the file transfer plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-157082948
Merged this to master:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;a=commit;h=cdeec1c59fd8fcfa9159ad733081ac93ec060f5a
Github repo is out of sync now though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-153656740
@jeroenv, I agree to @purplecabbage' reply to the dev-list:
> Post a picture that fails so we can verify.
I have tested this with Google Drive - still no repro.
Which server do you use for upload? Does it reproduce with [cordova-vm](https://github.com/apache/cordova-plugin-file-transfer/blob/066acb33aff08e97f6bbb1bd1b9141e9e8238cd1/tests/tests.js#L42)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by jeroenv <gi...@git.apache.org>.
Github user jeroenv commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-154436541
@daserge All pictures selected from Dropbox fail when i use File Transfer plugin together with Crosswalk Webview.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-151555981
Thanks, @jeroenv!
Please don't forget to sign the ICLA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org