Re: [I] Change Expr `PartialOrd` to not rely on comparing hash values [datafusion]

["ngli-me (via GitHub)" <gi...@apache.org>]

ngli-me commented on issue #8932:
URL: https://github.com/apache/datafusion/issues/8932#issuecomment-2336510088

   Hi, I'm new to this project and was poking through the issues, can I try working this one out?
    
   It looks like, to remove the hash we would need to first compare by enum variant (it looks like based on the test that the declaration order determines the Ord). I see two solutions for this, either implementing a "discriminant" function to determine the variant ordering, or by having a lot of match arms. 
   
   In the case of equivalent variant, we can then compare by fields, looks like it should work for the majority of them.
   
   Is that the right track?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org