You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/02/14 07:46:48 UTC

[GitHub] [tomcat] chaitan64arun opened a new pull request #241: Increment ReleaseIdle Counter when testAllIdle releases them

chaitan64arun opened a new pull request #241: Increment ReleaseIdle Counter when testAllIdle releases them
URL: https://github.com/apache/tomcat/pull/241
 
 
   In Tomcat JDBC module, I reckon PoolCleaner cleans the idle connections in two ways
   
   - checkIdle
   - testAllIdle
   
   `releasedIdleCount` is incremented when released from `checkIdle` but not from `testAllIdle`. Is it part of the design? If so, can we get more information about why it is not counted?
   
   IMO, the counter should be incremented in `testAllIdle` too. This PR includes this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org