You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/07 20:47:36 UTC

[GitHub] [superset] craig-rueda commented on a diff in pull request #17319: fix(core): memory leak in memorized decorator

craig-rueda commented on code in PR #17319:
URL: https://github.com/apache/superset/pull/17319#discussion_r916268781


##########
superset/models/core.py:
##########
@@ -349,6 +349,29 @@ def get_sqla_engine(
         nullpool: bool = True,
         user_name: Optional[str] = None,
         source: Optional[utils.QuerySource] = None,
+    ) -> Engine:
+        cache_key = (

Review Comment:
   Shouldn't we removed `@memoized` from this method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org