You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/10 07:30:23 UTC

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11980: fix : Fix style for header (sqllab)

rusackas commented on a change in pull request #11980:
URL: https://github.com/apache/incubator-superset/pull/11980#discussion_r539936887



##########
File path: superset-frontend/src/SqlLab/components/TableElement.jsx
##########
@@ -200,8 +201,14 @@ class TableElement extends React.PureComponent {
   renderHeader() {
     const { table } = this.props;
     return (
-      <div className="clearfix">
-        <div className="pull-left">
+      <div className="clearfix header-container">
+        <Tooltip
+          id="copy-to-clipboard-tooltip"
+          placement="top"
+          style={{ cursor: 'pointer' }}

Review comment:
       Hmmm... we should probably add this to the base component. Not particularly worried about it for now, but worth considering it for another PR, since it may require some auditing of use cases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org