[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1701: [CELEBORN-785] Add a configuration to ensure that, in soft mode, indi…

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1701:
URL: https://github.com/apache/incubator-celeborn/pull/1701#discussion_r1258574096


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1930,6 +1931,15 @@ object CelebornConf extends Logging {
       .bytesConf(ByteUnit.BYTE)
       .createWithDefaultString("1m")
 
+  val WORKER_PARTITION_SPLIT_MAX_SIZE: ConfigEntry[Long] =
+    buildConf("celeborn.worker.shuffle.partitionSplit.max")
+      .withAlternative("celeborn.shuffle.partitionSplit.max")

Review Comment:
   I think we don't need ```withAlternative``` here, it's only used for backward compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org