You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by Andrew Jaquith <an...@gmail.com> on 2010/03/06 18:11:18 UTC
Removal of old UrlConstructors, WikiServlet
All --
I'm about to check in a batch of code. In it, I remove the
Short/ShortView URLConstructors. These aren't used any longer because
of the switch to StripesURLConstructor, which works identically to
DefaultURLConstructor.
Also: the DefaultUrlConstructor is merged into StripesUrlConstructor
(quite easy, really). The URLConstructor interface method parsePage()
is removed, also, because that is taken care of by the framework.
(It's also not really a "constructor" method...)
And, as a consequence, WikiServlet is also not needed. Its primary
function was to help decode short URLs, but that's done by
ShortUrlFilter now.
Any objections before I commit? Nothing breaks, no real changes other
than removal of dead code.
Andrew
Re: Removal of old UrlConstructors, WikiServlet
Posted by Andrew Jaquith <an...@gmail.com>.
One more thing -- with these checkins, our unit test pass rate rises
above 98% again for the first time in a while. Just 18 test failures
left, which I'll take a look at as time permits.
Andrew
On Sat, Mar 6, 2010 at 2:25 PM, Andrew Jaquith
<an...@gmail.com> wrote:
> Ok -- checked it all in. I should have also mentioned that SpamFilter
> was also essentially dead code -- everything in it was already done
> (better) by the content-inspection stack. So I eliminated that too.
>
> Janne and Dirk -- this checkin also implements the fixes to the JSPs
> that allow editors to specify their own resources. Dirk, we will
> probably want to make some adjustments to your (new) wysiwyg.jsp; I've
> made some preliminary tweaks that you should take a look at. I'm happy
> to help tweak the editor JSP and/or EditActionBean to make it work
> nicely.
>
> Andrew
>
> On Sat, Mar 6, 2010 at 1:32 PM, Harry Metske <ha...@gmail.com> wrote:
>> go ahead Andrew, "make my day" :-)
>>
>> regards,
>> Harry
>>
>> 2010/3/6 Andrew Jaquith <an...@gmail.com>
>>
>>> All --
>>>
>>> I'm about to check in a batch of code. In it, I remove the
>>> Short/ShortView URLConstructors. These aren't used any longer because
>>> of the switch to StripesURLConstructor, which works identically to
>>> DefaultURLConstructor.
>>>
>>> Also: the DefaultUrlConstructor is merged into StripesUrlConstructor
>>> (quite easy, really). The URLConstructor interface method parsePage()
>>> is removed, also, because that is taken care of by the framework.
>>> (It's also not really a "constructor" method...)
>>>
>>> And, as a consequence, WikiServlet is also not needed. Its primary
>>> function was to help decode short URLs, but that's done by
>>> ShortUrlFilter now.
>>>
>>> Any objections before I commit? Nothing breaks, no real changes other
>>> than removal of dead code.
>>>
>>> Andrew
>>>
>>
>
Re: Removal of old UrlConstructors, WikiServlet
Posted by Andrew Jaquith <an...@gmail.com>.
Ok -- checked it all in. I should have also mentioned that SpamFilter
was also essentially dead code -- everything in it was already done
(better) by the content-inspection stack. So I eliminated that too.
Janne and Dirk -- this checkin also implements the fixes to the JSPs
that allow editors to specify their own resources. Dirk, we will
probably want to make some adjustments to your (new) wysiwyg.jsp; I've
made some preliminary tweaks that you should take a look at. I'm happy
to help tweak the editor JSP and/or EditActionBean to make it work
nicely.
Andrew
On Sat, Mar 6, 2010 at 1:32 PM, Harry Metske <ha...@gmail.com> wrote:
> go ahead Andrew, "make my day" :-)
>
> regards,
> Harry
>
> 2010/3/6 Andrew Jaquith <an...@gmail.com>
>
>> All --
>>
>> I'm about to check in a batch of code. In it, I remove the
>> Short/ShortView URLConstructors. These aren't used any longer because
>> of the switch to StripesURLConstructor, which works identically to
>> DefaultURLConstructor.
>>
>> Also: the DefaultUrlConstructor is merged into StripesUrlConstructor
>> (quite easy, really). The URLConstructor interface method parsePage()
>> is removed, also, because that is taken care of by the framework.
>> (It's also not really a "constructor" method...)
>>
>> And, as a consequence, WikiServlet is also not needed. Its primary
>> function was to help decode short URLs, but that's done by
>> ShortUrlFilter now.
>>
>> Any objections before I commit? Nothing breaks, no real changes other
>> than removal of dead code.
>>
>> Andrew
>>
>
Re: Removal of old UrlConstructors, WikiServlet
Posted by Harry Metske <ha...@gmail.com>.
go ahead Andrew, "make my day" :-)
regards,
Harry
2010/3/6 Andrew Jaquith <an...@gmail.com>
> All --
>
> I'm about to check in a batch of code. In it, I remove the
> Short/ShortView URLConstructors. These aren't used any longer because
> of the switch to StripesURLConstructor, which works identically to
> DefaultURLConstructor.
>
> Also: the DefaultUrlConstructor is merged into StripesUrlConstructor
> (quite easy, really). The URLConstructor interface method parsePage()
> is removed, also, because that is taken care of by the framework.
> (It's also not really a "constructor" method...)
>
> And, as a consequence, WikiServlet is also not needed. Its primary
> function was to help decode short URLs, but that's done by
> ShortUrlFilter now.
>
> Any objections before I commit? Nothing breaks, no real changes other
> than removal of dead code.
>
> Andrew
>
Re: Removal of old UrlConstructors, WikiServlet
Posted by Janne Jalkanen <ja...@ecyrd.com>.
No problems, but I would expect a bit longer than 2 hrs of warning for large code removals, esp. considering timezones. If you're uncertain, I recommend a JIRA issue and a patch for review and 72 hrs of review time.
/Janne
On 6 Mar 2010, at 19:11, Andrew Jaquith wrote:
> All --
>
> I'm about to check in a batch of code. In it, I remove the
> Short/ShortView URLConstructors. These aren't used any longer because
> of the switch to StripesURLConstructor, which works identically to
> DefaultURLConstructor.
>
> Also: the DefaultUrlConstructor is merged into StripesUrlConstructor
> (quite easy, really). The URLConstructor interface method parsePage()
> is removed, also, because that is taken care of by the framework.
> (It's also not really a "constructor" method...)
>
> And, as a consequence, WikiServlet is also not needed. Its primary
> function was to help decode short URLs, but that's done by
> ShortUrlFilter now.
>
> Any objections before I commit? Nothing breaks, no real changes other
> than removal of dead code.
>
> Andrew