[GitHub] [druid] jihoonson commented on a change in pull request #10093: Add groupBy limitSpec to queryCache key

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #10093:
URL: https://github.com/apache/druid/pull/10093#discussion_r451039806



##########
File path: processing/src/test/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChestTest.java
##########
@@ -929,6 +930,64 @@ private void doTestCacheStrategy(final ValueType valueType, final Object dimValu
     Assert.assertEquals(typeAdjustedResult2, fromResultCacheResult);
   }
 
+  @Test
+  public void testQueryCacheKeyWithLimitSpec()
+  {
+    final GroupByQuery query1 = GroupByQuery

Review comment:
       Would you please add another query which has the same spec and `CTX_KEY_APPLY_LIMIT_PUSH_DOWN` of true in the context, and check the equality of the cache key of the query and `query1`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org