[GitHub] [beam] kennknowles commented on a change in pull request #16035: [BEAM-11936] Fix errorprone UnusedVariable in Runners

[GitBox <gi...@apache.org>]

kennknowles commented on a change in pull request #16035:
URL: https://github.com/apache/beam/pull/16035#discussion_r760511741



##########
File path: runners/core-java/src/test/java/org/apache/beam/runners/core/triggers/TriggerStateMachinesTest.java
##########
@@ -86,9 +86,6 @@ public void testStateMachineForAfterWatermark() {
         RunnerApi.Trigger.newBuilder()
             .setAfterEndOfWindow(RunnerApi.Trigger.AfterEndOfWindow.getDefaultInstance())
             .build();
-    AfterWatermarkStateMachine.FromEndOfWindow machine =
-        (AfterWatermarkStateMachine.FromEndOfWindow)
-            TriggerStateMachines.stateMachineForTrigger(trigger);

Review comment:
       Kind of weird that this exact logic is written twice. I don't know the origin, but I wonder if it was an automatic refactor last time!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org