You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/11 01:53:40 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request, #6022: arch/risc-v: Apply misaligned access handler for k210/bl602
no1wudi opened a new pull request, #6022:
URL: https://github.com/apache/incubator-nuttx/pull/6022
## Summary
Add a new option to use misaligned memory access for K210/BL602
## Impact
New function for K210/BL602
## Testing
Custom board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6022: arch/risc-v: Apply misaligned access handler for k210/bl602
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6022:
URL: https://github.com/apache/incubator-nuttx/pull/6022#discussion_r847467324
##########
arch/risc-v/src/common/Kconfig:
##########
@@ -27,3 +27,8 @@ config RISCV_TOOLCHAIN_GNU_RVGW
configured for riscv64-unknown-elf.
endchoice
+
+config RISCV_SOFT_MISALIGNED_HANDLER
Review Comment:
Remove SOFT_?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a diff in pull request #6022: arch/risc-v: Apply misaligned access handler for k210/bl602
Posted by GitBox <gi...@apache.org>.
no1wudi commented on code in PR #6022:
URL: https://github.com/apache/incubator-nuttx/pull/6022#discussion_r848058363
##########
arch/risc-v/src/common/Kconfig:
##########
@@ -27,3 +27,8 @@ config RISCV_TOOLCHAIN_GNU_RVGW
configured for riscv64-unknown-elf.
endchoice
+
+config RISCV_SOFT_MISALIGNED_HANDLER
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6022: arch/risc-v: Apply misaligned access handler for k210/bl602
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6022:
URL: https://github.com/apache/incubator-nuttx/pull/6022#discussion_r847467324
##########
arch/risc-v/src/common/Kconfig:
##########
@@ -27,3 +27,8 @@ config RISCV_TOOLCHAIN_GNU_RVGW
configured for riscv64-unknown-elf.
endchoice
+
+config RISCV_SOFT_MISALIGNED_HANDLER
Review Comment:
RISCV_SOFT_MISALIGNED_HANDLER->ARCH_MISALIGNED_HANDLER? and move to risc-v/Kconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6022: arch/risc-v: Apply misaligned access handler for k210/bl602
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6022:
URL: https://github.com/apache/incubator-nuttx/pull/6022#discussion_r848138089
##########
arch/risc-v/Kconfig:
##########
@@ -194,6 +196,17 @@ config ARCH_HAVE_S_MODE
bool
default n
+config ARCH_HAVE_MISALIGN_EXCEPTION
+ bool
+ default n
+ ---help---
+ The chip will raise a exception while misaligned memory access.
+
+config RISCV_MISALIGNED_HANDLER
+ bool "Software misaligned memory access handler"
+ depends on ARCH_HAVE_MISALIGN_EXCEPTION
+ default y
+
# Option to run NuttX in supervisor mode. This is obviously not usable in
Review Comment:
please use TABs in Kconfig files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6022: arch/risc-v: Apply misaligned access handler for k210/bl602
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6022:
URL: https://github.com/apache/incubator-nuttx/pull/6022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a diff in pull request #6022: arch/risc-v: Apply misaligned access handler for k210/bl602
Posted by GitBox <gi...@apache.org>.
no1wudi commented on code in PR #6022:
URL: https://github.com/apache/incubator-nuttx/pull/6022#discussion_r848188910
##########
arch/risc-v/Kconfig:
##########
@@ -194,6 +196,17 @@ config ARCH_HAVE_S_MODE
bool
default n
+config ARCH_HAVE_MISALIGN_EXCEPTION
+ bool
+ default n
+ ---help---
+ The chip will raise a exception while misaligned memory access.
+
+config RISCV_MISALIGNED_HANDLER
+ bool "Software misaligned memory access handler"
+ depends on ARCH_HAVE_MISALIGN_EXCEPTION
+ default y
+
# Option to run NuttX in supervisor mode. This is obviously not usable in
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6022: arch/risc-v: Apply misaligned access handler for k210/bl602
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6022:
URL: https://github.com/apache/incubator-nuttx/pull/6022#issuecomment-1096983554
ci error is fixed by https://github.com/apache/incubator-nuttx/pull/6055, let's merge this PR directly to save the resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org