You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/11/04 03:01:12 UTC

[jira] [Created] (QPID-4419) [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment

Robbie Gemmell created QPID-4419:
------------------------------------

             Summary: [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment
                 Key: QPID-4419
                 URL: https://issues.apache.org/jira/browse/QPID-4419
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker
    Affects Versions: 0.18
            Reporter: Robbie Gemmell
             Fix For: 0.19


A user recently asked for assistance (see mail thread: http://mail-archives.apache.org/mod_mbox/qpid-users/201210.mbox/%3C1351193413.33603.YahooMailNeo%40web161402.mail.bf1.yahoo.com%3E) in getting C++ clients working properly with the Java broker, and Java clients working properly with the C++ broker. In the discussion it seemed to become clear that the issue related to the [lack of] installed cyrus-sasl pacakges affecting the supported sasl mechanisms for the C++ client and broker.

In the case of C++ client -> Java broker this resulted in attempt to initiate a connection without specifying any Sasl mechanism. Instead of handling this by killing the connection with a clear reason, the broker was instead incorrectly sending a ConnectionTune reply and then subsequently killing the connection (apparently silently and without clear reason) as a side effect of a NullPointerException resulting from the previous lack of Sasl mechanism.

The broker handling of the missing Sasl mechanism should be improved such that the it doesnt incorrectly send the ConnectionTune and instead kills the connection immediately for the explicit reason that no mechnanism was specified.

The C++ client behaviour that leads to this situation will be addessed via QPID-4407

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Comment Edited] (QPID-4419) [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490134#comment-13490134 ] 

Robbie Gemmell edited comment on QPID-4419 at 11/4/12 2:17 AM:
---------------------------------------------------------------

Change commtited such that the connetion will be killed explicitly and the client will now see a message indicating why:

{noformat}
./spout -c 1 -b guest/guest@localhost queue
No Sasl mechanism was specified
2012-11-04 01:33:27 [Client] warning Broker closed connection: 320, No Sasl mechanism was specified
{noformat}


Rob, Could you review this change please?

Thanks,
Robbie
                
      was (Author: gemmellr):
    Rob, Could you review this change please?

Thanks,
Robbie
                  
> [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment
> -----------------------------------------------------------------------------------------------
>
>                 Key: QPID-4419
>                 URL: https://issues.apache.org/jira/browse/QPID-4419
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Rob Godfrey
>             Fix For: 0.19
>
>
> A user recently asked for assistance (see mail thread: http://mail-archives.apache.org/mod_mbox/qpid-users/201210.mbox/%3C1351193413.33603.YahooMailNeo%40web161402.mail.bf1.yahoo.com%3E) in getting C++ clients working properly with the Java broker, and Java clients working properly with the C++ broker. In the discussion it seemed to become clear that the issue related to the (lack of) installed cyrus-sasl pacakges affecting the supported sasl mechanisms for the C++ client and broker.
> In the case of C++ client -> Java broker this resulted in attempt to initiate a connection without specifying any Sasl mechanism. Instead of handling this by killing the connection with a clear reason, the broker was instead incorrectly sending a ConnectionTune reply and then subsequently killing the connection (apparently silently and without clear reason) as a side effect of a NullPointerException resulting from the previous lack of Sasl mechanism.
> The broker handling of the missing Sasl mechanism should be improved such that the it doesnt incorrectly send the ConnectionTune and instead kills the connection immediately for the explicit reason that no mechnanism was specified.
> The C++ client behaviour that leads to this situation will be addessed via QPID-4407

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Assigned] (QPID-4419) [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-4419:
------------------------------------

    Assignee: Robbie Gemmell
    
> [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment
> -----------------------------------------------------------------------------------------------
>
>                 Key: QPID-4419
>                 URL: https://issues.apache.org/jira/browse/QPID-4419
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.19
>
>
> A user recently asked for assistance (see mail thread: http://mail-archives.apache.org/mod_mbox/qpid-users/201210.mbox/%3C1351193413.33603.YahooMailNeo%40web161402.mail.bf1.yahoo.com%3E) in getting C++ clients working properly with the Java broker, and Java clients working properly with the C++ broker. In the discussion it seemed to become clear that the issue related to the (lack of) installed cyrus-sasl pacakges affecting the supported sasl mechanisms for the C++ client and broker.
> In the case of C++ client -> Java broker this resulted in attempt to initiate a connection without specifying any Sasl mechanism. Instead of handling this by killing the connection with a clear reason, the broker was instead incorrectly sending a ConnectionTune reply and then subsequently killing the connection (apparently silently and without clear reason) as a side effect of a NullPointerException resulting from the previous lack of Sasl mechanism.
> The broker handling of the missing Sasl mechanism should be improved such that the it doesnt incorrectly send the ConnectionTune and instead kills the connection immediately for the explicit reason that no mechnanism was specified.
> The C++ client behaviour that leads to this situation will be addessed via QPID-4407

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4419) [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-4419:
---------------------------------

    Description: 
A user recently asked for assistance (see mail thread: http://mail-archives.apache.org/mod_mbox/qpid-users/201210.mbox/%3C1351193413.33603.YahooMailNeo%40web161402.mail.bf1.yahoo.com%3E) in getting C++ clients working properly with the Java broker, and Java clients working properly with the C++ broker. In the discussion it seemed to become clear that the issue related to the (lack of) installed cyrus-sasl pacakges affecting the supported sasl mechanisms for the C++ client and broker.

In the case of C++ client -> Java broker this resulted in attempt to initiate a connection without specifying any Sasl mechanism. Instead of handling this by killing the connection with a clear reason, the broker was instead incorrectly sending a ConnectionTune reply and then subsequently killing the connection (apparently silently and without clear reason) as a side effect of a NullPointerException resulting from the previous lack of Sasl mechanism.

The broker handling of the missing Sasl mechanism should be improved such that the it doesnt incorrectly send the ConnectionTune and instead kills the connection immediately for the explicit reason that no mechnanism was specified.

The C++ client behaviour that leads to this situation will be addessed via QPID-4407

  was:
A user recently asked for assistance (see mail thread: http://mail-archives.apache.org/mod_mbox/qpid-users/201210.mbox/%3C1351193413.33603.YahooMailNeo%40web161402.mail.bf1.yahoo.com%3E) in getting C++ clients working properly with the Java broker, and Java clients working properly with the C++ broker. In the discussion it seemed to become clear that the issue related to the [lack of] installed cyrus-sasl pacakges affecting the supported sasl mechanisms for the C++ client and broker.

In the case of C++ client -> Java broker this resulted in attempt to initiate a connection without specifying any Sasl mechanism. Instead of handling this by killing the connection with a clear reason, the broker was instead incorrectly sending a ConnectionTune reply and then subsequently killing the connection (apparently silently and without clear reason) as a side effect of a NullPointerException resulting from the previous lack of Sasl mechanism.

The broker handling of the missing Sasl mechanism should be improved such that the it doesnt incorrectly send the ConnectionTune and instead kills the connection immediately for the explicit reason that no mechnanism was specified.

The C++ client behaviour that leads to this situation will be addessed via QPID-4407

    
> [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment
> -----------------------------------------------------------------------------------------------
>
>                 Key: QPID-4419
>                 URL: https://issues.apache.org/jira/browse/QPID-4419
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.18
>            Reporter: Robbie Gemmell
>             Fix For: 0.19
>
>
> A user recently asked for assistance (see mail thread: http://mail-archives.apache.org/mod_mbox/qpid-users/201210.mbox/%3C1351193413.33603.YahooMailNeo%40web161402.mail.bf1.yahoo.com%3E) in getting C++ clients working properly with the Java broker, and Java clients working properly with the C++ broker. In the discussion it seemed to become clear that the issue related to the (lack of) installed cyrus-sasl pacakges affecting the supported sasl mechanisms for the C++ client and broker.
> In the case of C++ client -> Java broker this resulted in attempt to initiate a connection without specifying any Sasl mechanism. Instead of handling this by killing the connection with a clear reason, the broker was instead incorrectly sending a ConnectionTune reply and then subsequently killing the connection (apparently silently and without clear reason) as a side effect of a NullPointerException resulting from the previous lack of Sasl mechanism.
> The broker handling of the missing Sasl mechanism should be improved such that the it doesnt incorrectly send the ConnectionTune and instead kills the connection immediately for the explicit reason that no mechnanism was specified.
> The C++ client behaviour that leads to this situation will be addessed via QPID-4407

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Assigned] (QPID-4419) [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-4419:
------------------------------------

    Assignee: Rob Godfrey  (was: Robbie Gemmell)

Rob, Could you review this change please?

Thanks,
Robbie
                
> [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment
> -----------------------------------------------------------------------------------------------
>
>                 Key: QPID-4419
>                 URL: https://issues.apache.org/jira/browse/QPID-4419
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Rob Godfrey
>             Fix For: 0.19
>
>
> A user recently asked for assistance (see mail thread: http://mail-archives.apache.org/mod_mbox/qpid-users/201210.mbox/%3C1351193413.33603.YahooMailNeo%40web161402.mail.bf1.yahoo.com%3E) in getting C++ clients working properly with the Java broker, and Java clients working properly with the C++ broker. In the discussion it seemed to become clear that the issue related to the (lack of) installed cyrus-sasl pacakges affecting the supported sasl mechanisms for the C++ client and broker.
> In the case of C++ client -> Java broker this resulted in attempt to initiate a connection without specifying any Sasl mechanism. Instead of handling this by killing the connection with a clear reason, the broker was instead incorrectly sending a ConnectionTune reply and then subsequently killing the connection (apparently silently and without clear reason) as a side effect of a NullPointerException resulting from the previous lack of Sasl mechanism.
> The broker handling of the missing Sasl mechanism should be improved such that the it doesnt incorrectly send the ConnectionTune and instead kills the connection immediately for the explicit reason that no mechnanism was specified.
> The C++ client behaviour that leads to this situation will be addessed via QPID-4407

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4419) [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-4419:
---------------------------------

    Status: Ready To Review  (was: In Progress)
    
> [Java Broker] incorrect handling of missing sasl mechanism during 0-10 connection establishment
> -----------------------------------------------------------------------------------------------
>
>                 Key: QPID-4419
>                 URL: https://issues.apache.org/jira/browse/QPID-4419
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.19
>
>
> A user recently asked for assistance (see mail thread: http://mail-archives.apache.org/mod_mbox/qpid-users/201210.mbox/%3C1351193413.33603.YahooMailNeo%40web161402.mail.bf1.yahoo.com%3E) in getting C++ clients working properly with the Java broker, and Java clients working properly with the C++ broker. In the discussion it seemed to become clear that the issue related to the (lack of) installed cyrus-sasl pacakges affecting the supported sasl mechanisms for the C++ client and broker.
> In the case of C++ client -> Java broker this resulted in attempt to initiate a connection without specifying any Sasl mechanism. Instead of handling this by killing the connection with a clear reason, the broker was instead incorrectly sending a ConnectionTune reply and then subsequently killing the connection (apparently silently and without clear reason) as a side effect of a NullPointerException resulting from the previous lack of Sasl mechanism.
> The broker handling of the missing Sasl mechanism should be improved such that the it doesnt incorrectly send the ConnectionTune and instead kills the connection immediately for the explicit reason that no mechnanism was specified.
> The C++ client behaviour that leads to this situation will be addessed via QPID-4407

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org