You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "LiaCastaneda (via GitHub)" <gi...@apache.org> on 2025/08/06 14:49:05 UTC
[PR] Fix RowConverter roundtrip for List of Dictionary [arrow-rs]
LiaCastaneda opened a new pull request, #8067:
URL: https://github.com/apache/arrow-rs/pull/8067
# Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
- Closes #NNN.
# Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
# What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
# Are these changes tested?
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
# Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RowConverter roundtrip for List of Dictionary [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #8067:
URL: https://github.com/apache/arrow-rs/pull/8067#discussion_r2257727970
##########
arrow-row/Cargo.toml:
##########
@@ -40,6 +40,7 @@ arrow-array = { workspace = true }
arrow-buffer = { workspace = true }
arrow-data = { workspace = true }
arrow-schema = { workspace = true }
+arrow-cast = { workspace = true}
Review Comment:
We ideally want to avoid doing this, as it adds a significant additional dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RowConverter roundtrip for List of Dictionary [arrow-rs]
Posted by "LiaCastaneda (via GitHub)" <gi...@apache.org>.
LiaCastaneda commented on PR #8067:
URL: https://github.com/apache/arrow-rs/pull/8067#issuecomment-3160907785
Thanks @tustvold , then I understand the solution on @ding-young 's PR https://github.com/apache/arrow-rs/pull/7627 would be what we want? since I understand it keeps the flattened List
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RowConverter roundtrip for List of Dictionary [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #8067:
URL: https://github.com/apache/arrow-rs/pull/8067#issuecomment-3160849076
I think the issue is that Datafusion is not handling the fact that row encoding "hydrates" dictionaries. It should be updated to understand that `List<Dictionary<...>>` will be converted to `List<...>`, much like it already handles this for the non-nested case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RowConverter roundtrip for List of Dictionary [arrow-rs]
Posted by "LiaCastaneda (via GitHub)" <gi...@apache.org>.
LiaCastaneda commented on PR #8067:
URL: https://github.com/apache/arrow-rs/pull/8067#issuecomment-3167503429
closing this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RowConverter roundtrip for List of Dictionary [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #8067:
URL: https://github.com/apache/arrow-rs/pull/8067#issuecomment-3160858091
See https://github.com/apache/arrow-rs/issues/7165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RowConverter roundtrip for List of Dictionary [arrow-rs]
Posted by "LiaCastaneda (via GitHub)" <gi...@apache.org>.
LiaCastaneda closed pull request #8067: Fix RowConverter roundtrip for List of Dictionary
URL: https://github.com/apache/arrow-rs/pull/8067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org