[GitHub] spark pull request #14088: [SPARK-16414] [YARN] Fix bugs for "Can not get us...

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14088#discussion_r70073453
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
    @@ -743,6 +735,14 @@ object ApplicationMaster extends Logging {
       def main(args: Array[String]): Unit = {
         SignalUtils.registerLogger(log)
         val amArgs = new ApplicationMasterArguments(args)
    +
    +    // Load the properties file with the Spark configuration and set entries as system properties,
    +    // so that user code run inside the AM also has access to them.
    --- End diff --
    
    It would be nice to extend the comment to say "we must do this before SparkHadoopUtil instantiated" so that someone doesn't come along later and move it again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org