You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/16 08:11:53 UTC
[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #4108: Remove unused session variables
EmmyMiao87 opened a new pull request #4108:
URL: https://github.com/apache/incubator-doris/pull/4108
Remove unused session variables named sql_select_limit.
Change-Id: I35244cd6e490638d08f86a5c08131ff3cdba80b6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4108: Remove unused session variables
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4108:
URL: https://github.com/apache/incubator-doris/pull/4108#discussion_r455623479
##########
File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -556,7 +548,8 @@ public void readFields(DataInput in) throws IOException {
queryCacheType = in.readInt();
autoIncrementIncrement = in.readInt();
maxAllowedPacket = in.readInt();
- sqlSelectLimit = in.readLong();
Review comment:
What is BWC?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4108: Remove unused session variables
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4108:
URL: https://github.com/apache/incubator-doris/pull/4108#issuecomment-661069749
Should not remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4108: Remove unused session variables
Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on a change in pull request #4108:
URL: https://github.com/apache/incubator-doris/pull/4108#discussion_r455606984
##########
File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -556,7 +548,8 @@ public void readFields(DataInput in) throws IOException {
queryCacheType = in.readInt();
autoIncrementIncrement = in.readInt();
maxAllowedPacket = in.readInt();
- sqlSelectLimit = in.readLong();
Review comment:
Maybe you should consider BWC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #4108: Remove unused session variables
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #4108:
URL: https://github.com/apache/incubator-doris/pull/4108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4108: Remove unused session variables
Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on a change in pull request #4108:
URL: https://github.com/apache/incubator-doris/pull/4108#discussion_r455879210
##########
File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -556,7 +548,8 @@ public void readFields(DataInput in) throws IOException {
queryCacheType = in.readInt();
autoIncrementIncrement = in.readInt();
maxAllowedPacket = in.readInt();
- sqlSelectLimit = in.readLong();
Review comment:
BackWardsCompatible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org