You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/17 09:08:37 UTC
[GitHub] [airflow] robinedwards opened a new pull request #7195:
[AIRFLOW-6582] Dagstats not applying dag_id filter
robinedwards opened a new pull request #7195: [AIRFLOW-6582] Dagstats not applying dag_id filter
URL: https://github.com/apache/airflow/pull/7195
A small bug i introduced by accident in 1.10.7. The filter was applied after the group by which took no effect so all dags were returned by the end point making the additional get parameter i added in 1.10.7 pointless.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] robinedwards closed pull request #7195: [AIRFLOW-6582]
Dagstats not applying dag_id filter
Posted by GitBox <gi...@apache.org>.
robinedwards closed pull request #7195: [AIRFLOW-6582] Dagstats not applying dag_id filter
URL: https://github.com/apache/airflow/pull/7195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] robinedwards commented on issue #7195: [AIRFLOW-6582]
Dagstats not applying dag_id filter
Posted by GitBox <gi...@apache.org>.
robinedwards commented on issue #7195: [AIRFLOW-6582] Dagstats not applying dag_id filter
URL: https://github.com/apache/airflow/pull/7195#issuecomment-575556565
Of course I was actual just on the train trying to figure out why the exiting tests pass as looking at them on paper they shouldn't
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] robinedwards commented on issue #7195: [AIRFLOW-6582]
Dagstats not applying dag_id filter
Posted by GitBox <gi...@apache.org>.
robinedwards commented on issue #7195: [AIRFLOW-6582] Dagstats not applying dag_id filter
URL: https://github.com/apache/airflow/pull/7195#issuecomment-575695393
Aha I thought I was going insane. It seems AIRFLOW-6238 didnt make it into 1.10.7 which is where this came from
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] robinedwards edited a comment on issue #7195:
[AIRFLOW-6582] Dagstats not applying dag_id filter
Posted by GitBox <gi...@apache.org>.
robinedwards edited a comment on issue #7195: [AIRFLOW-6582] Dagstats not applying dag_id filter
URL: https://github.com/apache/airflow/pull/7195#issuecomment-575556565
Of course I was actually just on the train trying to figure out why the exiting tests pass as looking at them on paper they shouldn't
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services