You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/08 11:17:58 UTC
[GitHub] [skywalking] hanahmily opened a new pull request #7680: Use the jre image as the base image
hanahmily opened a new pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680
Fixed #7597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#discussion_r704326400
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
-FROM golang:1.14 AS cli
-
-ARG COMMIT_HASH=9f267876493943716434fdaa30047a14c0b5b2d9
-ARG CLI_CODE=${COMMIT_HASH}.tar.gz
-ARG CLI_CODE_URL=https://github.com/apache/skywalking-cli/archive/${CLI_CODE}
-
-ENV CGO_ENABLED=0
-ENV GO111MODULE=on
-
-WORKDIR /cli
-
-ADD ${CLI_CODE_URL} .
-RUN tar -xf ${CLI_CODE} --strip 1
-RUN rm ${CLI_CODE}
-
-RUN mkdir -p /skywalking/bin/
-RUN make linux && mv bin/swctl-latest-linux-amd64 /skywalking/bin/swctl
+FROM apache/skywalking-base:8.7.0-es7 AS cli
Review comment:
Although this works for now, but when we begin to adopt infra-e2e (https://github.com/apache/skywalking/issues/7368) I think it's highly possible we will have to enhance CLI and then compile from source codes here, so what about just updating the `COMMIT_HASH` at line 21?
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
Review comment:
We need to update https://github.com/apache/skywalking/blob/edcf5926a84f4cc31d702f7014b9a6b5769d8b7a/.github/workflows/e2e.jdk-versions.yaml#L40 so that different versions of `jre` can be tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#discussion_r704329657
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
-FROM golang:1.14 AS cli
-
-ARG COMMIT_HASH=9f267876493943716434fdaa30047a14c0b5b2d9
-ARG CLI_CODE=${COMMIT_HASH}.tar.gz
-ARG CLI_CODE_URL=https://github.com/apache/skywalking-cli/archive/${CLI_CODE}
-
-ENV CGO_ENABLED=0
-ENV GO111MODULE=on
-
-WORKDIR /cli
-
-ADD ${CLI_CODE_URL} .
-RUN tar -xf ${CLI_CODE} --strip 1
-RUN rm ${CLI_CODE}
-
-RUN mkdir -p /skywalking/bin/
-RUN make linux && mv bin/swctl-latest-linux-amd64 /skywalking/bin/swctl
+FROM apache/skywalking-base:8.7.0-es7 AS cli
Review comment:
> Although this works for now, but when we begin to adopt infra-e2e (#7368) I think it's highly possible we will have to enhance CLI and then compile from source codes here, so what about just updating the `COMMIT_HASH` at line 21?
Well ignore this, the CLI in infra-e2e should be run outside of OAP container, so the changes here is OK to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#issuecomment-915239277
> @kezhenxu94 Should we keep merging this? I think we have no clue about the mvnw issue.
Let's merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#discussion_r704329657
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
-FROM golang:1.14 AS cli
-
-ARG COMMIT_HASH=9f267876493943716434fdaa30047a14c0b5b2d9
-ARG CLI_CODE=${COMMIT_HASH}.tar.gz
-ARG CLI_CODE_URL=https://github.com/apache/skywalking-cli/archive/${CLI_CODE}
-
-ENV CGO_ENABLED=0
-ENV GO111MODULE=on
-
-WORKDIR /cli
-
-ADD ${CLI_CODE_URL} .
-RUN tar -xf ${CLI_CODE} --strip 1
-RUN rm ${CLI_CODE}
-
-RUN mkdir -p /skywalking/bin/
-RUN make linux && mv bin/swctl-latest-linux-amd64 /skywalking/bin/swctl
+FROM apache/skywalking-base:8.7.0-es7 AS cli
Review comment:
> Although this works for now, but when we begin to adopt infra-e2e (#7368) I think it's highly possible we will have to enhance CLI and then compile from source codes here, so what about just updating the `COMMIT_HASH` at line 21?
Well ignore this, the CLI in infra-e2e should be run outside of OAP container, so the cane here is OK to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#discussion_r704348364
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
Review comment:
OK, seems we should take care of it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#discussion_r704341847
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
Review comment:
Gotcha. I also found some other `openjdk` in e2e tests, for example, istio relevant cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#issuecomment-915184255
> javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed:
@kezhenxu94 This seems definitely showing up in the agent testing. But always be good in other tests. I think something breaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#discussion_r704347792
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
Review comment:
> Do we have jre agent image already?
For Java agent, no, it's still using JDK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#issuecomment-915238415
@kezhenxu94 Should we keep merging this? I think we have no clue about the mvnw issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#discussion_r704343555
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
Review comment:
Do we have jre agent image already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#discussion_r704347248
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
-FROM golang:1.14 AS cli
-
-ARG COMMIT_HASH=9f267876493943716434fdaa30047a14c0b5b2d9
-ARG CLI_CODE=${COMMIT_HASH}.tar.gz
-ARG CLI_CODE_URL=https://github.com/apache/skywalking-cli/archive/${CLI_CODE}
-
-ENV CGO_ENABLED=0
-ENV GO111MODULE=on
-
-WORKDIR /cli
-
-ADD ${CLI_CODE_URL} .
-RUN tar -xf ${CLI_CODE} --strip 1
-RUN rm ${CLI_CODE}
-
-RUN mkdir -p /skywalking/bin/
-RUN make linux && mv bin/swctl-latest-linux-amd64 /skywalking/bin/swctl
+FROM apache/skywalking-base:8.7.0-es7 AS cli
Review comment:
~~Thanks for sharing this, I will update commit sha instead of switching back to released images to get CLI.~~
Ignore ^^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680#discussion_r704347248
##########
File path: docker/oap/Dockerfile.oap
##########
@@ -14,28 +14,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine'
+ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre'
-FROM golang:1.14 AS cli
-
-ARG COMMIT_HASH=9f267876493943716434fdaa30047a14c0b5b2d9
-ARG CLI_CODE=${COMMIT_HASH}.tar.gz
-ARG CLI_CODE_URL=https://github.com/apache/skywalking-cli/archive/${CLI_CODE}
-
-ENV CGO_ENABLED=0
-ENV GO111MODULE=on
-
-WORKDIR /cli
-
-ADD ${CLI_CODE_URL} .
-RUN tar -xf ${CLI_CODE} --strip 1
-RUN rm ${CLI_CODE}
-
-RUN mkdir -p /skywalking/bin/
-RUN make linux && mv bin/swctl-latest-linux-amd64 /skywalking/bin/swctl
+FROM apache/skywalking-base:8.7.0-es7 AS cli
Review comment:
Thanks for sharing this, I will update commit sha instead of switching back to released images to get CLI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7680: Use the jre image as the base image
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7680:
URL: https://github.com/apache/skywalking/pull/7680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org