You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/05/31 23:40:11 UTC

[Impala-ASF-CR] PROTOTYPE: IMPALA-12114: Pull in fix for THRIFT-5705 and add test

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19962


Change subject: PROTOTYPE: IMPALA-12114: Pull in fix for THRIFT-5705 and add test
......................................................................

PROTOTYPE: IMPALA-12114: Pull in fix for THRIFT-5705 and add test

This pulls in a new toolchain to get a Thrift with
the patch for THRIFT-5705. This fixes an issue where
idle clients using TLS are needlessly disconnected due
to a bug in the read retry count logic inside Thrift.

NOTE: This is using a toolchain that doesn't have a
valid Ubuntu 18 build, so it will need to be rebuilt.
It is otherwise valid.

Tests:
 - This modifies test_thrift_socket.py to make it do
   more idle polls and check that ImpalaShell is not
   disconnected. It fails without the THRIFT-5705 patch
   and passes now.

Change-Id: Ifc7704cba032a91b9fd0d5d54d1e0a7e17fb10bb
---
M bin/impala-config.sh
M shell/impala_shell.py
M tests/custom_cluster/test_thrift_socket.py
3 files changed, 24 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/19962/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc7704cba032a91b9fd0d5d54d1e0a7e17fb10bb
Gerrit-Change-Number: 19962
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12114: Pull in fix for THRIFT-5705 and add test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19962 )

Change subject: IMPALA-12114: Pull in fix for THRIFT-5705 and add test
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13155/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7704cba032a91b9fd0d5d54d1e0a7e17fb10bb
Gerrit-Change-Number: 19962
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 03:44:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12114: Pull in fix for THRIFT-5705 and add test

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Hello Riza Suminto, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19962

to look at the new patch set (#2).

Change subject: IMPALA-12114: Pull in fix for THRIFT-5705 and add test
......................................................................

IMPALA-12114: Pull in fix for THRIFT-5705 and add test

This pulls in a new toolchain to get a Thrift with
the patch for THRIFT-5705. This fixes an issue where
idle clients using TLS are needlessly disconnected due
to a bug in the read retry count logic inside Thrift.

Tests:
 - This modifies test_thrift_socket.py to make it do
   more idle polls and check that ImpalaShell is not
   disconnected. It fails without the THRIFT-5705 patch
   and passes now.

Change-Id: Ifc7704cba032a91b9fd0d5d54d1e0a7e17fb10bb
---
M bin/impala-config.sh
M shell/impala_shell.py
M tests/custom_cluster/test_thrift_socket.py
3 files changed, 24 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/19962/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc7704cba032a91b9fd0d5d54d1e0a7e17fb10bb
Gerrit-Change-Number: 19962
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12114: Pull in fix for THRIFT-5705 and add test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19962 )

Change subject: IMPALA-12114: Pull in fix for THRIFT-5705 and add test
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9362/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7704cba032a91b9fd0d5d54d1e0a7e17fb10bb
Gerrit-Change-Number: 19962
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 03:24:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12114: Pull in fix for THRIFT-5705 and add test

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19962 )

Change subject: IMPALA-12114: Pull in fix for THRIFT-5705 and add test
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19962/2/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/19962/2/shell/impala_shell.py@729
PS2, Line 729:       # Note: This specific string is used in tests to verify that we didn't
> We could extract this string to a class level constant.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7704cba032a91b9fd0d5d54d1e0a7e17fb10bb
Gerrit-Change-Number: 19962
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 19:53:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12114: Pull in fix for THRIFT-5705 and add test

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.

Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19962 )

Change subject: IMPALA-12114: Pull in fix for THRIFT-5705 and add test
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19962/2/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/19962/2/shell/impala_shell.py@729
PS2, Line 729:       # Note: This specific string is used in tests to verify that we didn't
We could extract this string to a class level constant.



-- 
To view, visit http://gerrit.cloudera.org:8080/19962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7704cba032a91b9fd0d5d54d1e0a7e17fb10bb
Gerrit-Change-Number: 19962
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 09:21:52 +0000
Gerrit-HasComments: Yes