You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/13 10:26:03 UTC
[GitHub] [incubator-dolphinscheduler] nauu opened a new pull request #1814:
fix bug, add the cache logic in getInstancedetail
nauu opened a new pull request #1814: fix bug, add the cache logic in getInstancedetail
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1814
## What is the purpose of the pull request
Fix the bug in #1795, add a instance cache.
## Brief change log
- *Edit actions.js*
- *Edit formModel.vue*
## Verify this pull request
This change added tests and can be verified as follows:
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] break60 commented on issue #1814: fix
bug, add the cache logic in getInstancedetail
Posted by GitBox <gi...@apache.org>.
break60 commented on issue #1814: fix bug, add the cache logic in getInstancedetail
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1814#issuecomment-573596531
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1814: fix bug, add the cache logic in getInstancedetail
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1814: fix bug, add the cache logic in getInstancedetail
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1814#issuecomment-573600647
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1814&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1814&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1814&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1814&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1814&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1814:
fix bug, add the cache logic in getInstancedetail
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1814: fix bug, add the cache logic in getInstancedetail
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1814
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1814: fix bug, add the cache logic in getInstancedetail
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1814: fix bug, add the cache logic in getInstancedetail
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1814#issuecomment-573598336
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=h1) Report
> Merging [#1814](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/289ae6ac96857dc965a05f37285def8cbc4a5b34?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1814 +/- ##
=====================================
Coverage 21.4% 21.4%
=====================================
Files 293 293
Lines 14051 14051
Branches 2316 2316
=====================================
Hits 3007 3007
Misses 10717 10717
Partials 327 327
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=footer). Last update [289ae6a...b938f48](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1814:
fix bug, add the cache logic in getInstancedetail
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1814: fix bug, add the cache logic in getInstancedetail
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1814#issuecomment-573598336
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=h1) Report
> Merging [#1814](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/289ae6ac96857dc965a05f37285def8cbc4a5b34?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1814 +/- ##
=========================================
- Coverage 21.4% 21.39% -0.01%
=========================================
Files 293 293
Lines 14051 14051
Branches 2316 2316
=========================================
- Hits 3007 3006 -1
- Misses 10717 10718 +1
Partials 327 327
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=footer). Last update [289ae6a...b938f48](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue
#1814: fix bug, add the cache logic in getInstancedetail
Posted by GitBox <gi...@apache.org>.
xingchun-chen commented on issue #1814: fix bug, add the cache logic in getInstancedetail
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1814#issuecomment-574477291
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services