[PR] Support mysql, doris insert & replace rows statement parse [shardingsphere]

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu opened a new pull request, #38585:
URL: https://github.com/apache/shardingsphere/pull/38585

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     - Support mysql, doris insert & replace rows statement parse
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support mysql, doris insert & replace rows statement parse [shardingsphere]

["FlyingZC (via GitHub)" <gi...@apache.org>]

FlyingZC merged PR #38585:
URL: https://github.com/apache/shardingsphere/pull/38585


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support mysql, doris insert & replace rows statement parse [shardingsphere]

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu commented on PR #38585:
URL: https://github.com/apache/shardingsphere/pull/38585#issuecomment-4174199890

   • Decision
   
     - Merge Verdict: Mergeable
     - Reviewed Scope: parser/sql/engine/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/engine/mysql/visitor/statement/MySQLStatementVisitor.java:1568, parser/sql/engine/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/engine/
       doris/visitor/statement/DorisStatementVisitor.java:1596, test/it/parser/src/main/resources/sql/supported/dml/insert.xml:48, test/it/parser/src/main/resources/sql/supported/dml/replace.xml:36, parser/sql/statement/core/src/main/java/org/apache/
       shardingsphere/sql/parser/statement/core/extractor/ExpressionExtractor.java:302, parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/dml/InsertStatement.java:91
     - Not Reviewed Scope: Other dialect visitors, binder/routing/execution layers, full parser IT suite
     - Need Expert Review: No
   
     Basis
   
     - Your clarification about the official documentation boundary is correct. Hive and Presto should not be treated as regression targets for this PR, so I am withdrawing the previous blocker about those dialects.
     - The PR is now aligned with its implementation target: both MySQL and Doris visitInsertValuesClause() and visitReplaceValuesClause() now branch on ctx.rowConstructorList(), which directly closes the original parsing gap for batch ROW(...) values.
     - I rechecked the latest diff and did not find any shared execution-path change or fallback-order change. I also did not find evidence that InsertStatement’s InsertValuesSegment position fields are consumed by a critical downstream path, so the risk stays
       localized to the parser layer.
     - The new parser IT cases cover the MySQL/Doris batch row-constructor happy path for both insert and replace, and they map one-to-one to the fix.
   
     Pre-merge Check
   
     - I did not rerun Maven locally in this pass.
     - Based on the latest diff, the official docs boundary, and the current test additions, I do not see a blocking issue.
   
     Sources
   
     - MySQL INSERT docs (https://dev.mysql.com/doc/refman/8.0/en/insert.html)
     - MySQL REPLACE docs (https://dev.mysql.com/doc/refman/8.0/en/replace.html)
     - Presto INSERT docs (https://prestodb.io/docs/current/sql/insert.html)
     - Hive DML docs (https://hive.apache.org/docs/latest/language/languagemanual-dml/)
   
     This PR is mergeable.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org