You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/29 08:44:31 UTC

[GitHub] [incubator-kyuubi] zhouyifan279 commented on a change in pull request #1312: [KYUUBI #1300] Detecting critical errors

zhouyifan279 commented on a change in pull request #1312:
URL: https://github.com/apache/incubator-kyuubi/pull/1312#discussion_r739046300



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkThriftBinaryFrontendService.scala
##########
@@ -147,6 +147,10 @@ class SparkThriftBinaryFrontendService(
       s"${serverAddr.getHostAddress}:$portNum"
     }
   }
+
+  override protected def oomHook: Runnable = {
+    () => discoveryService.foreach(_.stop())

Review comment:
       Why call `discoveryService.stop()` instead of `serverable.stop()` ?
   Maybe we should leave some comment here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org