You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jr...@apache.org on 2017/03/14 18:41:45 UTC

[1/2] incubator-impala git commit: IMPALA-4643: [DOCS] Turn UDF github links into keyrefs

Repository: incubator-impala
Updated Branches:
  refs/heads/master 1240e329e -> d4b0b5682


IMPALA-4643: [DOCS] Turn UDF github links into keyrefs

Remove some UDF-related URLs pointing to /cloudera/ github
from the XML source.

The HTML links still point to /cloudera/ URLs, but those can
be re-pointed easily without touching this same source file.

Also change some /user/cloudera/ references to an HDFS
user name.

Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Reviewed-on: http://gerrit.cloudera.org:8080/6388
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/bc514899
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/bc514899
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/bc514899

Branch: refs/heads/master
Commit: bc514899e0d20fcef39ddb776337fd01e9c4c550
Parents: 1240e32
Author: John Russell <jr...@cloudera.com>
Authored: Tue Mar 14 10:01:08 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Tue Mar 14 17:59:55 2017 +0000

----------------------------------------------------------------------
 docs/topics/impala_udf.xml | 38 +++++++++++++++++---------------------
 1 file changed, 17 insertions(+), 21 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/bc514899/docs/topics/impala_udf.xml
----------------------------------------------------------------------
diff --git a/docs/topics/impala_udf.xml b/docs/topics/impala_udf.xml
index f385baf..ad2ad07 100644
--- a/docs/topics/impala_udf.xml
+++ b/docs/topics/impala_udf.xml
@@ -233,8 +233,8 @@ select real_words(letters) from word_games;</codeblock>
         <ol>
           <li>
             Take a copy of the Hive JAR file containing the Hive built-in functions. For example, the path might be
-            like <filepath>/usr/lib/hive/lib/hive-exec-0.10.0-cdh4.2.0.jar</filepath>, with different version
-            numbers corresponding to your specific level of CDH.
+            like <filepath>/usr/lib/hive/lib/hive-exec-0.10.0.jar</filepath>, with different version
+            numbers corresponding to your specific level of <keyword keyref="distro"/>.
           </li>
 
           <li>
@@ -440,8 +440,8 @@ Returned 1 row(s) in 0.11s</codeblock>
 
       <p>
         When you are ready to start writing your own UDFs, download the sample code and build scripts from
-        <xref href="https://github.com/cloudera/impala-udf-samples" scope="external" format="html">the Cloudera
-        sample UDF github</xref>. Then see <xref href="impala_udf.xml#udf_coding"/> for how to code UDFs, and
+        <xref keyref="udf-samples">the Impala sample UDF github</xref>.
+        Then see <xref href="impala_udf.xml#udf_coding"/> for how to code UDFs, and
         <xref href="impala_udf.xml#udf_tutorial"/> for how to build and run UDFs.
       </p>
     </conbody>
@@ -501,7 +501,7 @@ Returned 1 row(s) in 0.11s</codeblock>
 
         <p>
           For the basic declarations needed to write a scalar UDF, see the header file
-          <xref href="https://github.com/cloudera/impala-udf-samples/blob/master/udf-sample.h" scope="external" format="html"><filepath>udf-sample.h</filepath></xref>
+          <xref keyref="udf-sample.h"><filepath>udf-sample.h</filepath></xref>
           within the sample build environment, which defines a simple function
           named <codeph>AddUdf()</codeph>:
         </p>
@@ -968,9 +968,7 @@ within UDAs, you can return without specifying a value.
           <filepath>uda-sample.h</filepath>:
         </p>
 
-        <p> See this file online at: <xref
-            href="https://github.com/cloudera/impala-udf-samples/blob/master/uda-sample.h"
-            scope="external" format="html" /></p>
+        <p> See this file online at: <xref keyref="uda-sample.h"/></p>
 
 <codeblock audience="hidden">#ifndef SAMPLES_UDA_H
 #define SAMPLES_UDA_H
@@ -982,7 +980,7 @@ using namespace impala_udf;
 // This is an example of the COUNT aggregate function.
 //
 // Usage: &gt; create aggregate function my_count(int) returns bigint
-//          location '/user/cloudera/libudasample.so' update_fn='CountUpdate';
+//          location '/user/doc_demo/libudasample.so' update_fn='CountUpdate';
 //        &gt; select my_count(col) from tbl;
 
 void CountInit(FunctionContext* context, BigIntVal* val);
@@ -997,7 +995,7 @@ BigIntVal CountFinalize(FunctionContext* context, const BigIntVal&amp; val);
 // 16 bytes (8 byte sum + 8 byte count) as the size for this buffer.
 //
 // Usage: &gt; create aggregate function my_avg(double) returns string
-//          location '/user/cloudera/libudasample.so' update_fn='AvgUpdate';
+//          location '/user/doc_demo/libudasample.so' update_fn='AvgUpdate';
 //        &gt; select cast(my_avg(col) as double) from tbl;
 
 void AvgInit(FunctionContext* context, StringVal* val);
@@ -1010,7 +1008,7 @@ StringVal AvgFinalize(FunctionContext* context, const StringVal&amp; val);
 // This is a sample of implementing the STRING_CONCAT aggregate function.
 //
 // Usage: &gt; create aggregate function string_concat(string, string) returns string
-//          location '/user/cloudera/libudasample.so' update_fn='StringConcatUpdate';
+//          location '/user/doc_demo/libudasample.so' update_fn='StringConcatUpdate';
 //        &gt; select string_concat(string_col, ",") from table;
 
 void StringConcatInit(FunctionContext* context, StringVal* val);
@@ -1024,7 +1022,7 @@ StringVal StringConcatFinalize(FunctionContext* context, const StringVal&amp; va
 // This is a example of the variance aggregate function.
 //
 // Usage: &gt; create aggregate function var(double) returns string
-//          location '/user/cloudera/libudasample.so' update_fn='VarianceUpdate';
+//          location '/user/doc_demo/libudasample.so' update_fn='VarianceUpdate';
 //        &gt; select cast(var(col) as double) from tbl;
 
 void VarianceInit(FunctionContext* context, StringVal* val);
@@ -1038,7 +1036,7 @@ StringVal VarianceFinalize(FunctionContext* context, const StringVal&amp; val);
 // more numerically stable.
 //
 // Usage: &gt; create aggregate function knuth_var(double) returns string
-//          location '/user/cloudera/libudasample.so' update_fn='KnuthVarianceUpdate';
+//          location '/user/doc_demo/libudasample.so' update_fn='KnuthVarianceUpdate';
 //        &gt; select cast(knuth_var(col) as double) from tbl;
 
 void KnuthVarianceInit(FunctionContext* context, StringVal* val);
@@ -1052,7 +1050,7 @@ StringVal KnuthVarianceFinalize(FunctionContext* context, const StringVal&amp; v
 // other steps from the Knuth variance computation.
 //
 // Usage: &gt; create aggregate function stddev(double) returns string
-//          location '/user/cloudera/libudasample.so' update_fn='KnuthVarianceUpdate'
+//          location '/user/doc_demo/libudasample.so' update_fn='KnuthVarianceUpdate'
 //          finalize_fn="StdDevFinalize";
 //        &gt; select cast(stddev(col) as double) from tbl;
 
@@ -1069,9 +1067,7 @@ StringVal ToStringVal(FunctionContext* context, const T&amp; val);
           <filepath>uda-sample.cc</filepath>:
         </p>
 
-        <p> See this file online at: <xref
-            href="https://github.com/cloudera/impala-udf-samples/blob/master/uda-sample.cc"
-            scope="external" format="html" />
+        <p> See this file online at: <xref keyref="uda-sample.cc"/>
         </p>
 
 <codeblock audience="hidden">#include "uda-sample.h"
@@ -1269,9 +1265,9 @@ StringVal StringConcatFinalize(FunctionContext* context, const StringVal&amp; va
           For an example of this technique, see the <codeph>trunc_sum()</codeph> aggregate function, which accumulates
           intermediate results of type <codeph>DOUBLE</codeph> and returns <codeph>BIGINT</codeph> at the end.
           View
-          <xref href="https://github.com/cloudera/Impala/blob/cdh5-trunk/tests/query_test/test_udfs.py" scope="external" format="html">the <codeph>CREATE FUNCTION</codeph> statement</xref>
+          <xref keyref="test_udfs.py">the <codeph>CREATE FUNCTION</codeph> statement</xref>
           and
-          <xref href="http://github.com/Cloudera/Impala/blob/cdh5-trunk/be/src/testutil/test-udas.cc" scope="external" format="html">the implementation of the underlying TruncSum*() functions</xref>
+          <xref keyref="test-udas.cc">the implementation of the underlying TruncSum*() functions</xref>
           on Github.
         </p>
       </conbody>
@@ -1448,8 +1444,8 @@ make</codeblock>
 
       <p>
         For downloadable examples that you can experiment with, adapt, and use as templates for your own functions,
-        see <xref href="https://github.com/cloudera/impala-udf-samples" scope="external" format="html">the Cloudera
-        sample UDF github</xref>. You must have already installed the appropriate header files, as explained in
+        see <xref keyref="udf-samples" scope="external" format="html">the Impala sample UDF github</xref>.
+        You must have already installed the appropriate header files, as explained in
         <xref href="impala_udf.xml#udf_demo_env"/>.
       </p>
 


[2/2] incubator-impala git commit: [DOCS] Remove obsolete commented stuff from impala_fixed_issues

Posted by jr...@apache.org.
[DOCS] Remove obsolete commented stuff from impala_fixed_issues

The impala_fixed_issues page included commented
lists of JIRAs including URLs of non-public
Google docs prepared by the CCE team. Take 'em out.

Also in one case where 'CDH' was intentionally left in
the topic of a subtitle, 'CDH' can still be removed from
the cause/workaround text.

Change-Id: I4383811dc25ebd1c326cbd1e12a985848da3abb5
Reviewed-on: http://gerrit.cloudera.org:8080/6390
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/d4b0b568
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/d4b0b568
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/d4b0b568

Branch: refs/heads/master
Commit: d4b0b568227cb1b52e77cdf72f29548ee0f68030
Parents: bc51489
Author: John Russell <jr...@cloudera.com>
Authored: Tue Mar 14 10:55:30 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Tue Mar 14 18:22:32 2017 +0000

----------------------------------------------------------------------
 docs/topics/impala_fixed_issues.xml | 96 +-------------------------------
 1 file changed, 1 insertion(+), 95 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/d4b0b568/docs/topics/impala_fixed_issues.xml
----------------------------------------------------------------------
diff --git a/docs/topics/impala_fixed_issues.xml b/docs/topics/impala_fixed_issues.xml
index 7cb4b32..1ee1a13 100644
--- a/docs/topics/impala_fixed_issues.xml
+++ b/docs/topics/impala_fixed_issues.xml
@@ -1147,34 +1147,6 @@ IMPALA-1917
 
     </conbody>
 
-<!-- List of fixed issues from Juan Yu's spreadsheet: https://docs.google.com/spreadsheets/d/1Ia06xOLKQInKfsJzQfQ6Sf1fO3nYLOpZ-0OWfFNgNSc/edit#gid=1566007471
-
-Asterisks indicate the ones that are considered critical and so get a writeup here.
-
-* 5ff1062 IMPALA-1459: Fix migration/assignment of On-clause predicates inside inline views.
-* bcea8cf IMPALA-2446: Fix wrong predicate assignment in outer joins
-* 8e010af IMPALA-2648/IMPALA-2664: Avoid sending large partition stats objects over thrift
-7e3a789 IMPALA-2260: Adding a large hour interval caused an interval overflow
-* 9a86c94 IMPALA-1675: Avoid overflow when adding large intervals to TIMESTAMPs
-1a83dfc IMPALA-2086, IMPALA-2090: Avoid boost year/month interval logic
-* 1d0b017 IMPALA-1949: Analysis exception when a binary operator contain an IN operator with
-0ae066f IMPALA-2141: UnionNode::GetNext() doesn't check for query errors
-* 31824ad IMPALA-2273: Make MAX_PAGE_HEADER_SIZE configurable
-75497ca IMPALA-2559: Fix check failed: sorter_runs_.back()->is_pinned_
-ddfe66f IMPALA-2265: Sorter was not checking the returned Status of PrepareRead
-* a39a2a5 IMPALA-2357: Fix spilling sorts with var-len slots that are NULL or empty.
-04bcfb9 IMPALA-0000: Fix reporting of custom OOM error messages.
-d9d2a10 IMPALA-0000: Log backtrace on all MEM_LIMIT_EXCEEDED errors
-* 4210021 IMPALA-0000: Work-around IMPALA-2344: Fail query with OOM in case block->Pin() fails
-29d7b42 IMPALA-2286: Fix race between ~BufferedBlockMgr() and BufferedBlockMgr::Creat
-* d87a306 IMPALA-2252: Crash (likely race) tearing down BufferedBlockMgr on query failu
-* a1bb4a6 IMPALA-1746: QueryExecState doesn't check for query cancellation or errors
-* e9ff989 IMPALA-2533: Impala throws IllegalStateException when inserting data into a p
-
-* c22683a IMPALA-1917: Do not register aux equivalence predicates with NULL on either side.
-* c0a7393 IMPALA-2731: Refactor MemPool usage in HBase scan node.
--->
-
     <concept id="IMPALA-1917">
       <!-- Title in Juan's spreadsheet. Actual JIRA title more useful for readers IMO. <title>Do not register aux equivalence predicates with NULL on either side.</title> -->
       <title>Query return empty result if it contains NullLiteral in inlineview</title>
@@ -1466,30 +1438,6 @@ d93fb5a IMPALA-1899: Cleanup handling of Hive's field schema
       </p>
 
     </conbody>
-<!--
-8736dba IMPALA-1983: Warn if table stats are potentially corrupt.
-a0911fc IMPALA-2266: Pass correct child node in 2nd phase merge aggregation.
-3183878 IMPALA-2216: Set the output smap of an EmptySetNode produced from an empty inline view.
-a73d008 IMPALA-2203: Set an InsertStmt's result exprs from the source statement's result exprs.
-e641759 IMPALA-2088: Fix planning of empty union operands with analytics.
-752b3bd IMPALA-1756: Constant filter expressions are not checked for errors and state cleanup is not done before throwing exception.
-d703959 IMPALA-2239: update misc.test to match the new .test file format
-8dddd60 IMPALA-2089: Retain eq predicates bound by grouping slots with complex grouping exprs.
-ce9fa25 IMPALA-2201: Unconditionally update the partition stats and row count.
-ff5bc02 IMPALA-2199: Row count not set for empty partition when spec is used with compute incremental stats
-3eb2d80 IMPALA-1898: Explicit aliases + ordinals analysis bug
-ba6a8bf IMPALA-1987: Fix TupleIsNullPredicate to return false if no tuples are nullable.
-932d4f8 IMPALA-2178: fix Expr::ComputeResultsLayout() logic
-4ef0bd8 IMPALA-1737: Substitute an InsertStmt's partition key exprs with the root node's smap.
-
-Per Juan Yu, almost all of those are critical issues related to query correctness.
-The non-critical ones are:
-
-752b3bd IMPALA-1756: Constant filter expressions are not checked for errors and state cleanup is not done before throwing exception.
-d703959 IMPALA-2239: update misc.test to match the new .test file format
-ce9fa25 IMPALA-2201: Unconditionally update the partition stats and row count.
-
--->
 
     <concept id="IMPALA-1983">
       <title>Warn if table stats are potentially corrupt.</title>
@@ -1654,22 +1602,6 @@ ce9fa25 IMPALA-2201: Unconditionally update the partition stats and row count.
 
     </conbody>
 
-<!--
-7c01049 IMPALA-1929: Avoiding a DCHECK of NULL hash table in spilled right joins
-c98a556 IMPALA-2136: Bug in PrintTColumnValue caused wrong stats for TINYINT partition cols
-* 4390a5c Making sure that there are no regressions due to IMPALA-2065
-* 33ee7df IMPALA-2133: Properly unescape string value for HBase filters
-* 562b61a IMPALA-1735: ExpandRmReservation only check parent pools with limit
-* 5b09eaa IMPALA-2101: fix NULL ptr deref in BufferedBlockMgr::PinBlock
-c2b8852 IMPALA-2018: Where clause does not propagate to joins inside nested views
-16b79ce IMPALA-2064: Add effective_user() builtin
-99a282b IMPALA-2125: Make UTC to local TimestampValue conversion faster.
-9198985 IMPALA-2065: Workaround IMPALA-1619 in BufferedBlockMgr::ConsumeMemory()
-9ce94eb IMPALA-2048: Set the correct input format when updating partition metadata
-
-* = non-critical to document according to Juan Yu.
--->
-
     <concept id="IMPALA-2048">
       <title>Impala DML/DDL operations corrupt table metadata leading to Hive query failures</title>
       <conbody>
@@ -1776,23 +1708,6 @@ c2b8852 IMPALA-2018: Where clause does not propagate to joins inside nested view
 
     </conbody>
 
-<!-- List of fixed issues from Juan's spreadsheet: https://docs.google.com/spreadsheets/d/1Ia06xOLKQInKfsJzQfQ6Sf1fO3nYLOpZ-0OWfFNgNSc/edit#gid=1566007471
-b782f02 IMPALA-1963: Impala Timestamp ISO-8601 Support.
-a0ce91e IMPALA-2043: skip metadata/testddl.py#test_create_alter_bulk_parition on S3
-191f150 CDH-27688: Isilon: fix custom_cluster/test_insert_inherit_permission.py
-ae39894 IMPALA-1968: Part 1: Improve planner numNodes estimate for remote scans
-0d12492 IMPALA-1730: reduce scanner thread spinning windows
-80c2ee3 CDH-26785: Isilon: add remote HDFS disk queue
-19533f6 IMPALA-2002: Provide way to cache ext data source classes
-f847370 IMPALA-2008: Fix wrong warning when insert overwrite to empty table
-81b6f27 IMPALA-1381: Expand set of supported timezones.
-2dcf1ec IMPALA-1952: Expand parsing of decimals to include scientific notation
-9053970 : Isilon: don't warn for multiple remote parquet blocks
-a94d401 : Enable isilon end to end tests for Impala.
-3062d5d : Add flag to skip HBase pytests
-ce601ec : Enable using isilon as the underlying filesystem.
--->
-
     <concept id="isilon_support">
       <title>Enable using Isilon as the underlying filesystem.</title>
       <conbody>
@@ -2104,15 +2019,6 @@ IMPALA-1607
       </p>
 
     </conbody>
-<!--
-5e7e50d IMPALA-1917: Do not register aux equivalence predicates with NULL on either side.
-d8856bd IMPALA-2264: fix edge cases for decimal/integer cast
-c17890e IMPALA-2514: DCHECK on destroying an ExprContext
-2befc12 IMPALA-1746: QueryExecState doesn't check for query cancellation or errors
-e591cf4 IMPALA-2141: UnionNode::GetNext() doesn't check for query errors
-76b5313 IMPALA-1756: Constant filter expressions are not checked for errors and state clea
-* 6a98b7c Don't redirect stdout/stderr from BE tests
--->
 
     <concept id="IMPALA-1917-539">
       <!-- Title in Juan's spreadsheet. Actual JIRA title more useful for readers IMO. <title>Do not register aux equivalence predicates with NULL on either side.</title> -->
@@ -4813,7 +4719,7 @@ Bad stats:
         </p>
 
         <p>
-          <b>Resolution:</b> The underlying issue is being addressed by a fix in the CDH Parquet libraries. Impala
+          <b>Resolution:</b> The underlying issue is being addressed by a fix in the Parquet libraries. Impala
           1.2.2 works around the problem and reads the existing data files.
         </p>
       </conbody>