[GitHub] [arrow] pitrou opened a new issue, #34003: [C++] AddWithOverflow and friends should be [[nodiscard]]

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou opened a new issue, #34003:
URL: https://github.com/apache/arrow/issues/34003

   ### Describe the enhancement requested
   
   Users shouldn't ignore the boolean value returned by the `AddWithOverflow` and similar helpers, as it indicates whether an integer overflow actually occurred.
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wgtmac commented on issue #34003: [C++] AddWithOverflow and friends should be [[nodiscard]]

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on issue #34003:
URL: https://github.com/apache/arrow/issues/34003#issuecomment-1413911346

   Let me fix it :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed issue #34003: [C++] AddWithOverflow and friends should be [[nodiscard]]

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou closed issue #34003: [C++] AddWithOverflow and friends should be [[nodiscard]]
URL: https://github.com/apache/arrow/issues/34003


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org