You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/09 23:34:16 UTC
[GitHub] [spark] planga82 opened a new pull request #33950: [SPARK-36698][SQL] Allow expand 'quotedRegexColumnNames' in all expressions when it’s expanded to one named expression
planga82 opened a new pull request #33950:
URL: https://github.com/apache/spark/pull/33950
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
With `spark.sql.parser.quotedRegexColumnNames=true` regular expressions are not allowed in expressions like
``` SELECT `col_.*`/exp FROM (SELECT 3 AS col_a, 1 as exp) ```
This PR propose to improve this behavior and allow this regular expression when it expands to only one named expression. It’s the same behavior in Hive.
Example 1:
```
SELECT `col_.*`/exp FROM (SELECT 3 AS col_a, 1 as exp)
```
col_.* expands to col_a: OK
Example 2:
```
SELECT `col_.*`/col_b FROM (SELECT 3 AS col_a, 1 as col_b)
```
col_.* expands to (col_a, col_b) : Fail like now
Example 3:
```
SELECT `col_a`/exp FROM (SELECT 3 AS col_a, 1 as exp)
```
col_a expands to col_a: OK
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Improve this feature and approaching hive behavior
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #33950: [SPARK-36698][SQL] Allow expand 'quotedRegexColumnNames' in all expressions when it’s expanded to one named expression
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #33950:
URL: https://github.com/apache/spark/pull/33950#issuecomment-999952887
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33950: [SPARK-36698][SQL] Allow expand 'quotedRegexColumnNames' in all expressions when it’s expanded to one named expression
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33950:
URL: https://github.com/apache/spark/pull/33950#issuecomment-917942679
Personally, I think this feature looks confusing. Can we get some feedback from our real users first? By sending emails to user/dev list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33950: [SPARK-36698][SQL] Allow expand 'quotedRegexColumnNames' in all expressions when it’s expanded to one named expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33950:
URL: https://github.com/apache/spark/pull/33950#issuecomment-917537541
BTW, is this a valid syntax in other DBMSes or ANSI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] planga82 commented on pull request #33950: [SPARK-36698][SQL] Allow expand 'quotedRegexColumnNames' in all expressions when it’s expanded to one named expression
Posted by GitBox <gi...@apache.org>.
planga82 commented on pull request #33950:
URL: https://github.com/apache/spark/pull/33950#issuecomment-916511632
CC @HyukjinKwon
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] planga82 commented on pull request #33950: [SPARK-36698][SQL] Allow expand 'quotedRegexColumnNames' in all expressions when it’s expanded to one named expression
Posted by GitBox <gi...@apache.org>.
planga82 commented on pull request #33950:
URL: https://github.com/apache/spark/pull/33950#issuecomment-917700540
I haven't found functionality like this in other DBMS or ANSI. Hive is the only reference I have found and I believe it was the reference when the functionality was developed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33950: [SPARK-36698][SQL] Allow expand 'quotedRegexColumnNames' in all expressions when it’s expanded to one named expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33950:
URL: https://github.com/apache/spark/pull/33950#issuecomment-917537439
I have less context on this. cc @cloud-fan, @janewangfb and @gatorsmile from git-blame.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33950: [SPARK-36698][SQL] Allow expand 'quotedRegexColumnNames' in all expressions when it’s expanded to one named expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33950:
URL: https://github.com/apache/spark/pull/33950#issuecomment-916511111
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #33950: [SPARK-36698][SQL] Allow expand 'quotedRegexColumnNames' in all expressions when it’s expanded to one named expression
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #33950:
URL: https://github.com/apache/spark/pull/33950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org