You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/23 08:02:11 UTC

[GitHub] [flink] wenlong88 opened a new pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

wenlong88 opened a new pull request #14472:
URL: https://github.com/apache/flink/pull/14472


   ## Brief change log
   1. introduce BatchPhysicalLimit, StreamPhysicalLimit, StreamPhysicalRank and rename related Rule.
   2. make StreamExecLimit extends from StreamExecRank, to reuse all of the shared code
   
   
   ## Verifying this change
   This change is already covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3dc6318b3d973b44a187339521599c2c4aa7910 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78cd30e32d782920ef421aadb46cec2e51a49dd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0d54a6ae4bbd0a1f014b367206b518d474daf9a4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258) 
   * 5c7245dc954e1a6a987d1af12b2b8b65807f2f92 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wenlong88 commented on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
wenlong88 commented on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-751151175


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78cd30e32d782920ef421aadb46cec2e51a49dd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238) 
   * d4f99052af27fc5da2d29974727d4a71ab3542c0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe closed pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14472:
URL: https://github.com/apache/flink/pull/14472


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-751252395


   Thanks for the update, LGTM except some minor adjustments, I will do this in my local and then merge the pr once azure is green


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78cd30e32d782920ef421aadb46cec2e51a49dd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238) 
   * d4f99052af27fc5da2d29974727d4a71ab3542c0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d4f99052af27fc5da2d29974727d4a71ab3542c0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252) 
   * 4732e646bc7e544fa19d6c2ddd59a493f717522b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255) 
   * 0d54a6ae4bbd0a1f014b367206b518d474daf9a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5c7245dc954e1a6a987d1af12b2b8b65807f2f92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275) 
   * d3dc6318b3d973b44a187339521599c2c4aa7910 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9135cbb7f107ee96b15de4b0a3453d60ee5b9de6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78cd30e32d782920ef421aadb46cec2e51a49dd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238) 
   * d4f99052af27fc5da2d29974727d4a71ab3542c0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252) 
   * 4732e646bc7e544fa19d6c2ddd59a493f717522b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255) 
   * 0d54a6ae4bbd0a1f014b367206b518d474daf9a4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b04180b32ac8950c9dabaa7f8142ed6bff033304",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b04180b32ac8950c9dabaa7f8142ed6bff033304",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9135cbb7f107ee96b15de4b0a3453d60ee5b9de6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298) 
   * b04180b32ac8950c9dabaa7f8142ed6bff033304 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78cd30e32d782920ef421aadb46cec2e51a49dd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238) 
   * d4f99052af27fc5da2d29974727d4a71ab3542c0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252) 
   * 4732e646bc7e544fa19d6c2ddd59a493f717522b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255) 
   * 0d54a6ae4bbd0a1f014b367206b518d474daf9a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3dc6318b3d973b44a187339521599c2c4aa7910 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297) 
   * 9135cbb7f107ee96b15de4b0a3453d60ee5b9de6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on a change in pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14472:
URL: https://github.com/apache/flink/pull/14472#discussion_r548365445



##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecLimit.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.batch;
+
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.streaming.api.operators.SimpleOperatorFactory;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.nodes.exec.utils.ExecNodeUtil;
+import org.apache.flink.table.runtime.operators.sort.LimitOperator;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import java.util.Collections;
+
+/**
+ * Batch {@link ExecNode} for Calc.
+ */
+public class BatchExecLimit extends ExecNodeBase<RowData> implements BatchExecNode<RowData> {
+
+	private boolean isGlobal;
+	private long limitStart;
+	private long limitEnd;

Review comment:
       mark them as final

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecRank.java
##########
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.stream;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.streaming.api.operators.KeyedProcessOperator;
+import org.apache.flink.streaming.api.transformations.OneInputTransformation;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.codegen.EqualiserCodeGenerator;
+import org.apache.flink.table.planner.codegen.sort.ComparatorCodeGenerator;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.utils.AppendFastStrategy$;
+import org.apache.flink.table.planner.plan.utils.KeySelectorUtil;
+import org.apache.flink.table.planner.plan.utils.RankProcessStrategy;
+import org.apache.flink.table.planner.plan.utils.RetractStrategy$;
+import org.apache.flink.table.planner.plan.utils.UpdateFastStrategy;
+import org.apache.flink.table.runtime.generated.GeneratedRecordComparator;
+import org.apache.flink.table.runtime.generated.GeneratedRecordEqualiser;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.operators.rank.AbstractTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.AppendOnlyTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.ComparableRecordComparator;
+import org.apache.flink.table.runtime.operators.rank.RankRange;
+import org.apache.flink.table.runtime.operators.rank.RankType;
+import org.apache.flink.table.runtime.operators.rank.RetractableTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.UpdatableTopNFunction;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+
+import java.util.Collections;
+import java.util.stream.IntStream;
+
+/**
+ * Stream {@link ExecNode} for Rank.
+ */
+public class StreamExecRank extends ExecNodeBase<RowData> implements StreamExecNode<RowData> {
+
+	// It is a experimental config, will may be removed later.
+	@Experimental
+	public static final ConfigOption<Long> TABLE_EXEC_TOPN_CACHE_SIZE =
+		ConfigOptions.key("table.exec.topn.cache-size")
+			.longType()
+			.defaultValue(10000L)
+			.withDescription("TopN operator has a cache which caches partial state contents to reduce" +
+				" state access. Cache size is the number of records in each TopN task.");
+
+	private RankType rankType;
+	private RankProcessStrategy rankStrategy;
+	private RankRange rankRange;
+	private boolean generateUpdateBefore;
+	private boolean outputRankNumber;
+	private int[] partitionFields;
+	private int[] sortFields;
+	private boolean[] sortDirections;
+	private boolean[] nullsIsLast;

Review comment:
       mark them as final. and I would like to suggest reorder the fields as: type part, partition part, order by part, range part, and other part. which could make read easier to understand, because it matches the order in sql definition.

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecRank.java
##########
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.stream;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.streaming.api.operators.KeyedProcessOperator;
+import org.apache.flink.streaming.api.transformations.OneInputTransformation;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.codegen.EqualiserCodeGenerator;
+import org.apache.flink.table.planner.codegen.sort.ComparatorCodeGenerator;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.utils.AppendFastStrategy$;
+import org.apache.flink.table.planner.plan.utils.KeySelectorUtil;
+import org.apache.flink.table.planner.plan.utils.RankProcessStrategy;
+import org.apache.flink.table.planner.plan.utils.RetractStrategy$;
+import org.apache.flink.table.planner.plan.utils.UpdateFastStrategy;
+import org.apache.flink.table.runtime.generated.GeneratedRecordComparator;
+import org.apache.flink.table.runtime.generated.GeneratedRecordEqualiser;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.operators.rank.AbstractTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.AppendOnlyTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.ComparableRecordComparator;
+import org.apache.flink.table.runtime.operators.rank.RankRange;
+import org.apache.flink.table.runtime.operators.rank.RankType;
+import org.apache.flink.table.runtime.operators.rank.RetractableTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.UpdatableTopNFunction;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+
+import java.util.Collections;
+import java.util.stream.IntStream;
+
+/**
+ * Stream {@link ExecNode} for Rank.
+ */
+public class StreamExecRank extends ExecNodeBase<RowData> implements StreamExecNode<RowData> {
+
+	// It is a experimental config, will may be removed later.
+	@Experimental
+	public static final ConfigOption<Long> TABLE_EXEC_TOPN_CACHE_SIZE =
+		ConfigOptions.key("table.exec.topn.cache-size")
+			.longType()
+			.defaultValue(10000L)
+			.withDescription("TopN operator has a cache which caches partial state contents to reduce" +
+				" state access. Cache size is the number of records in each TopN task.");
+
+	private RankType rankType;
+	private RankProcessStrategy rankStrategy;
+	private RankRange rankRange;
+	private boolean generateUpdateBefore;
+	private boolean outputRankNumber;
+	private int[] partitionFields;
+	private int[] sortFields;
+	private boolean[] sortDirections;
+	private boolean[] nullsIsLast;
+
+	public StreamExecRank(
+			RankType rankType,
+			RankProcessStrategy rankStrategy,
+			RankRange rankRange,
+			boolean generateUpdateBefore,
+			boolean outputRankNumber,
+			int[] partitionFields,
+			int[] sortFields,
+			boolean[] sortDirections,
+			boolean[] nullsIsLast,
+			ExecEdge inputEdge,
+			LogicalType outputType,
+			String description) {
+		super(Collections.singletonList(inputEdge), outputType, description);
+		this.rankType = rankType;
+		this.rankStrategy = rankStrategy;
+		this.rankRange = rankRange;
+		this.generateUpdateBefore = generateUpdateBefore;
+		this.outputRankNumber = outputRankNumber;
+		this.partitionFields = partitionFields;
+		this.sortFields = sortFields;
+		this.sortDirections = sortDirections;
+		this.nullsIsLast = nullsIsLast;
+	}
+
+	@Override
+	protected Transformation<RowData> translateToPlanInternal(PlannerBase planner) {
+		switch (rankType) {
+			case ROW_NUMBER:
+				break;
+			case RANK:
+				throw new TableException("RANK() on streaming table is not supported currently");
+			case DENSE_RANK:
+				throw new TableException("DENSE_RANK() on streaming table is not supported currently");
+			default:
+				throw new TableException(String.format("Streaming tables do not support %s rank function.", rankType));
+		}
+
+		TableConfig tableConfig = planner.getTableConfig();
+
+		RowType inputType = (RowType) getInputNodes().get(0).getOutputType();
+		InternalTypeInfo<RowData> inputRowTypeInfo = InternalTypeInfo.of(inputType);
+		RowDataKeySelector sortKeySelector = KeySelectorUtil.getRowDataSelector(sortFields, inputRowTypeInfo);
+		LogicalType[] sortKeyTypes = IntStream.of(sortFields).mapToObj(inputType::getTypeAt).toArray(LogicalType[]::new);
+		int[] sortKeyPositions = IntStream.range(0, sortFields.length).toArray();
+		GeneratedRecordComparator sortKeyComparator = ComparatorCodeGenerator.gen(
+				tableConfig,
+				"StreamExecSortComparator",
+				sortKeyPositions,
+				sortKeyTypes,
+				sortDirections,
+				nullsIsLast);
+		long cacheSize = tableConfig.getConfiguration().getLong(TABLE_EXEC_TOPN_CACHE_SIZE);
+		long minIdleStateRetentionTime = tableConfig.getMinIdleStateRetentionTime();
+		long maxIdleStateRetentionTime = tableConfig.getMaxIdleStateRetentionTime();
+
+		AbstractTopNFunction processFunction;
+		if (rankStrategy instanceof AppendFastStrategy$) {

Review comment:
       it's better we could port `AppendFastStrategy` to Java ? it's a little strange to see `$`

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecLimit.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.batch;
+
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.streaming.api.operators.SimpleOperatorFactory;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.nodes.exec.utils.ExecNodeUtil;
+import org.apache.flink.table.runtime.operators.sort.LimitOperator;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import java.util.Collections;
+
+/**
+ * Batch {@link ExecNode} for Calc.

Review comment:
       incorrect comment

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecLimit.java
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.stream;
+
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.utils.AppendFastStrategy$;
+import org.apache.flink.table.planner.plan.utils.RankProcessStrategy;
+import org.apache.flink.table.planner.plan.utils.RetractStrategy$;
+import org.apache.flink.table.runtime.operators.rank.ConstantRankRange;
+import org.apache.flink.table.runtime.operators.rank.RankType;
+import org.apache.flink.table.types.logical.LogicalType;
+
+/**
+ * Stream {@link ExecNode} for Limit.
+ */
+public class StreamExecLimit extends StreamExecRank implements StreamExecNode<RowData> {

Review comment:
       `implements StreamExecNode<RowData>` is unnecessary

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecLimit.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.batch;
+
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.streaming.api.operators.SimpleOperatorFactory;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.nodes.exec.utils.ExecNodeUtil;
+import org.apache.flink.table.runtime.operators.sort.LimitOperator;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import java.util.Collections;
+
+/**
+ * Batch {@link ExecNode} for Calc.
+ */
+public class BatchExecLimit extends ExecNodeBase<RowData> implements BatchExecNode<RowData> {
+
+	private boolean isGlobal;
+	private long limitStart;
+	private long limitEnd;
+
+	public BatchExecLimit(
+		boolean isGlobal,
+		long limitStart,
+		long limitEnd,
+		ExecEdge inputEdge,
+		LogicalType outputType,
+		String description) {
+		super(Collections.singletonList(inputEdge), outputType, description);
+		this.isGlobal = isGlobal;
+		this.limitStart = limitStart;
+		this.limitEnd = limitEnd;
+	}
+
+	@Override

Review comment:
       add `@SuppressWarnings("unchecked")` to make IDE happy

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecRank.java
##########
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.stream;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.streaming.api.operators.KeyedProcessOperator;
+import org.apache.flink.streaming.api.transformations.OneInputTransformation;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.codegen.EqualiserCodeGenerator;
+import org.apache.flink.table.planner.codegen.sort.ComparatorCodeGenerator;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.utils.AppendFastStrategy$;
+import org.apache.flink.table.planner.plan.utils.KeySelectorUtil;
+import org.apache.flink.table.planner.plan.utils.RankProcessStrategy;
+import org.apache.flink.table.planner.plan.utils.RetractStrategy$;
+import org.apache.flink.table.planner.plan.utils.UpdateFastStrategy;
+import org.apache.flink.table.runtime.generated.GeneratedRecordComparator;
+import org.apache.flink.table.runtime.generated.GeneratedRecordEqualiser;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.operators.rank.AbstractTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.AppendOnlyTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.ComparableRecordComparator;
+import org.apache.flink.table.runtime.operators.rank.RankRange;
+import org.apache.flink.table.runtime.operators.rank.RankType;
+import org.apache.flink.table.runtime.operators.rank.RetractableTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.UpdatableTopNFunction;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+
+import java.util.Collections;
+import java.util.stream.IntStream;
+
+/**
+ * Stream {@link ExecNode} for Rank.
+ */
+public class StreamExecRank extends ExecNodeBase<RowData> implements StreamExecNode<RowData> {
+
+	// It is a experimental config, will may be removed later.
+	@Experimental
+	public static final ConfigOption<Long> TABLE_EXEC_TOPN_CACHE_SIZE =
+		ConfigOptions.key("table.exec.topn.cache-size")
+			.longType()
+			.defaultValue(10000L)
+			.withDescription("TopN operator has a cache which caches partial state contents to reduce" +
+				" state access. Cache size is the number of records in each TopN task.");
+
+	private RankType rankType;
+	private RankProcessStrategy rankStrategy;
+	private RankRange rankRange;
+	private boolean generateUpdateBefore;
+	private boolean outputRankNumber;
+	private int[] partitionFields;
+	private int[] sortFields;
+	private boolean[] sortDirections;
+	private boolean[] nullsIsLast;
+
+	public StreamExecRank(
+			RankType rankType,
+			RankProcessStrategy rankStrategy,
+			RankRange rankRange,
+			boolean generateUpdateBefore,
+			boolean outputRankNumber,
+			int[] partitionFields,
+			int[] sortFields,
+			boolean[] sortDirections,
+			boolean[] nullsIsLast,
+			ExecEdge inputEdge,
+			LogicalType outputType,
+			String description) {
+		super(Collections.singletonList(inputEdge), outputType, description);
+		this.rankType = rankType;
+		this.rankStrategy = rankStrategy;
+		this.rankRange = rankRange;
+		this.generateUpdateBefore = generateUpdateBefore;
+		this.outputRankNumber = outputRankNumber;
+		this.partitionFields = partitionFields;
+		this.sortFields = sortFields;
+		this.sortDirections = sortDirections;
+		this.nullsIsLast = nullsIsLast;
+	}
+
+	@Override
+	protected Transformation<RowData> translateToPlanInternal(PlannerBase planner) {
+		switch (rankType) {
+			case ROW_NUMBER:
+				break;
+			case RANK:
+				throw new TableException("RANK() on streaming table is not supported currently");
+			case DENSE_RANK:
+				throw new TableException("DENSE_RANK() on streaming table is not supported currently");
+			default:
+				throw new TableException(String.format("Streaming tables do not support %s rank function.", rankType));
+		}
+
+		TableConfig tableConfig = planner.getTableConfig();
+
+		RowType inputType = (RowType) getInputNodes().get(0).getOutputType();
+		InternalTypeInfo<RowData> inputRowTypeInfo = InternalTypeInfo.of(inputType);
+		RowDataKeySelector sortKeySelector = KeySelectorUtil.getRowDataSelector(sortFields, inputRowTypeInfo);
+		LogicalType[] sortKeyTypes = IntStream.of(sortFields).mapToObj(inputType::getTypeAt).toArray(LogicalType[]::new);
+		int[] sortKeyPositions = IntStream.range(0, sortFields.length).toArray();
+		GeneratedRecordComparator sortKeyComparator = ComparatorCodeGenerator.gen(
+				tableConfig,
+				"StreamExecSortComparator",
+				sortKeyPositions,
+				sortKeyTypes,
+				sortDirections,
+				nullsIsLast);
+		long cacheSize = tableConfig.getConfiguration().getLong(TABLE_EXEC_TOPN_CACHE_SIZE);
+		long minIdleStateRetentionTime = tableConfig.getMinIdleStateRetentionTime();
+		long maxIdleStateRetentionTime = tableConfig.getMaxIdleStateRetentionTime();
+
+		AbstractTopNFunction processFunction;
+		if (rankStrategy instanceof AppendFastStrategy$) {
+			processFunction = new AppendOnlyTopNFunction(
+					minIdleStateRetentionTime,
+					maxIdleStateRetentionTime,
+					inputRowTypeInfo,
+					sortKeyComparator,
+					sortKeySelector,
+					rankType,
+					rankRange,
+					generateUpdateBefore,
+					outputRankNumber,
+					cacheSize);
+		} else if (rankStrategy instanceof UpdateFastStrategy) {
+			UpdateFastStrategy updateFastStrategy = (UpdateFastStrategy) rankStrategy;
+			int[] primaryKeys = updateFastStrategy.primaryKeys();
+			RowDataKeySelector rowKeySelector = KeySelectorUtil.getRowDataSelector(
+					primaryKeys,
+					inputRowTypeInfo);
+			processFunction = new UpdatableTopNFunction(
+					minIdleStateRetentionTime,
+					maxIdleStateRetentionTime,
+					inputRowTypeInfo,
+					rowKeySelector,
+					sortKeyComparator,
+					sortKeySelector,
+					rankType,
+					rankRange,
+					generateUpdateBefore,
+					outputRankNumber,
+					cacheSize);
+		// TODO Use UnaryUpdateTopNFunction after SortedMapState is merged
+		} else if (rankStrategy instanceof RetractStrategy$) {
+			EqualiserCodeGenerator equaliserCodeGen = new EqualiserCodeGenerator(
+					inputType.getFields().stream().map(field -> field.getType()).toArray(LogicalType[]::new));
+			GeneratedRecordEqualiser generatedEqualiser = equaliserCodeGen.generateRecordEqualiser("RankValueEqualiser");
+			ComparableRecordComparator comparator = new ComparableRecordComparator(
+					sortKeyComparator,
+					sortKeyPositions,
+					sortKeyTypes,
+					sortDirections,
+					nullsIsLast);
+			processFunction = new RetractableTopNFunction(
+					minIdleStateRetentionTime,
+					maxIdleStateRetentionTime,
+					inputRowTypeInfo,
+					comparator,
+					sortKeySelector,
+					rankType,
+					rankRange,
+					generatedEqualiser,
+					generateUpdateBefore,
+					outputRankNumber);
+		} else {
+			throw new TableException(String.format("rank strategy:%s is not supported.", rankStrategy));
+		}
+
+		KeyedProcessOperator operator = new KeyedProcessOperator(processFunction);

Review comment:
       nit: add type parameter ?

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecLimit.java
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.stream;
+
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.utils.AppendFastStrategy$;
+import org.apache.flink.table.planner.plan.utils.RankProcessStrategy;
+import org.apache.flink.table.planner.plan.utils.RetractStrategy$;
+import org.apache.flink.table.runtime.operators.rank.ConstantRankRange;
+import org.apache.flink.table.runtime.operators.rank.RankType;
+import org.apache.flink.table.types.logical.LogicalType;
+
+/**
+ * Stream {@link ExecNode} for Limit.
+ */
+public class StreamExecLimit extends StreamExecRank implements StreamExecNode<RowData> {
+
+	private final long limitEnd;
+
+	public StreamExecLimit(
+		long limitStart,
+		long limitEnd,
+		boolean generateUpdateBefore,
+		boolean insertOnly,
+		ExecEdge inputEdge,
+		LogicalType outputType,
+		String description) {
+		super(
+			RankType.ROW_NUMBER,
+			getRankStrategy(insertOnly),
+			new ConstantRankRange(limitStart + 1, limitEnd),
+			generateUpdateBefore,
+			false,
+			new int[0],
+			new int[0],
+			new boolean[0],
+			new boolean[0],
+			inputEdge,
+			outputType,
+			description);
+		this.limitEnd = limitEnd;
+	}
+
+	private static RankProcessStrategy getRankStrategy(boolean insertOnly) {
+		if (insertOnly) {
+			return AppendFastStrategy$.MODULE$;
+		} else {
+			return RetractStrategy$.MODULE$;

Review comment:
       port them to java?

##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecRank.java
##########
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.stream;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.streaming.api.operators.KeyedProcessOperator;
+import org.apache.flink.streaming.api.transformations.OneInputTransformation;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.codegen.EqualiserCodeGenerator;
+import org.apache.flink.table.planner.codegen.sort.ComparatorCodeGenerator;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.utils.AppendFastStrategy$;
+import org.apache.flink.table.planner.plan.utils.KeySelectorUtil;
+import org.apache.flink.table.planner.plan.utils.RankProcessStrategy;
+import org.apache.flink.table.planner.plan.utils.RetractStrategy$;
+import org.apache.flink.table.planner.plan.utils.UpdateFastStrategy;
+import org.apache.flink.table.runtime.generated.GeneratedRecordComparator;
+import org.apache.flink.table.runtime.generated.GeneratedRecordEqualiser;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.operators.rank.AbstractTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.AppendOnlyTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.ComparableRecordComparator;
+import org.apache.flink.table.runtime.operators.rank.RankRange;
+import org.apache.flink.table.runtime.operators.rank.RankType;
+import org.apache.flink.table.runtime.operators.rank.RetractableTopNFunction;
+import org.apache.flink.table.runtime.operators.rank.UpdatableTopNFunction;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+
+import java.util.Collections;
+import java.util.stream.IntStream;
+
+/**
+ * Stream {@link ExecNode} for Rank.
+ */
+public class StreamExecRank extends ExecNodeBase<RowData> implements StreamExecNode<RowData> {
+
+	// It is a experimental config, will may be removed later.
+	@Experimental
+	public static final ConfigOption<Long> TABLE_EXEC_TOPN_CACHE_SIZE =
+		ConfigOptions.key("table.exec.topn.cache-size")
+			.longType()
+			.defaultValue(10000L)
+			.withDescription("TopN operator has a cache which caches partial state contents to reduce" +
+				" state access. Cache size is the number of records in each TopN task.");
+
+	private RankType rankType;
+	private RankProcessStrategy rankStrategy;
+	private RankRange rankRange;
+	private boolean generateUpdateBefore;
+	private boolean outputRankNumber;
+	private int[] partitionFields;
+	private int[] sortFields;
+	private boolean[] sortDirections;
+	private boolean[] nullsIsLast;
+
+	public StreamExecRank(
+			RankType rankType,
+			RankProcessStrategy rankStrategy,
+			RankRange rankRange,
+			boolean generateUpdateBefore,
+			boolean outputRankNumber,
+			int[] partitionFields,
+			int[] sortFields,
+			boolean[] sortDirections,
+			boolean[] nullsIsLast,
+			ExecEdge inputEdge,
+			LogicalType outputType,
+			String description) {
+		super(Collections.singletonList(inputEdge), outputType, description);
+		this.rankType = rankType;
+		this.rankStrategy = rankStrategy;
+		this.rankRange = rankRange;
+		this.generateUpdateBefore = generateUpdateBefore;
+		this.outputRankNumber = outputRankNumber;
+		this.partitionFields = partitionFields;
+		this.sortFields = sortFields;
+		this.sortDirections = sortDirections;
+		this.nullsIsLast = nullsIsLast;
+	}
+
+	@Override

Review comment:
       nit: add `@SuppressWarnings("unchecked")`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226) 
   * 78cd30e32d782920ef421aadb46cec2e51a49dd5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b04180b32ac8950c9dabaa7f8142ed6bff033304",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11330",
       "triggerID" : "b04180b32ac8950c9dabaa7f8142ed6bff033304",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9135cbb7f107ee96b15de4b0a3453d60ee5b9de6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298) 
   * b04180b32ac8950c9dabaa7f8142ed6bff033304 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11330) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4732e646bc7e544fa19d6c2ddd59a493f717522b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255) 
   * 0d54a6ae4bbd0a1f014b367206b518d474daf9a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3dc6318b3d973b44a187339521599c2c4aa7910 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297) 
   * 9135cbb7f107ee96b15de4b0a3453d60ee5b9de6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "b04180b32ac8950c9dabaa7f8142ed6bff033304",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11330",
       "triggerID" : "b04180b32ac8950c9dabaa7f8142ed6bff033304",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b04180b32ac8950c9dabaa7f8142ed6bff033304 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11330) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-749997470


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3 (Wed Dec 23 08:04:57 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78cd30e32d782920ef421aadb46cec2e51a49dd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238) 
   * d4f99052af27fc5da2d29974727d4a71ab3542c0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252) 
   * 4732e646bc7e544fa19d6c2ddd59a493f717522b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5c7245dc954e1a6a987d1af12b2b8b65807f2f92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9135cbb7f107ee96b15de4b0a3453d60ee5b9de6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0d54a6ae4bbd0a1f014b367206b518d474daf9a4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9135cbb7f107ee96b15de4b0a3453d60ee5b9de6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0d54a6ae4bbd0a1f014b367206b518d474daf9a4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258) 
   * 5c7245dc954e1a6a987d1af12b2b8b65807f2f92 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11255",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11258",
       "triggerID" : "0d54a6ae4bbd0a1f014b367206b518d474daf9a4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11275",
       "triggerID" : "5c7245dc954e1a6a987d1af12b2b8b65807f2f92",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11297",
       "triggerID" : "d3dc6318b3d973b44a187339521599c2c4aa7910",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9135cbb7f107ee96b15de4b0a3453d60ee5b9de6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298",
       "triggerID" : "751151175",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9135cbb7f107ee96b15de4b0a3453d60ee5b9de6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11316) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11298) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252",
       "triggerID" : "d4f99052af27fc5da2d29974727d4a71ab3542c0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4732e646bc7e544fa19d6c2ddd59a493f717522b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78cd30e32d782920ef421aadb46cec2e51a49dd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238) 
   * d4f99052af27fc5da2d29974727d4a71ab3542c0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11252) 
   * 4732e646bc7e544fa19d6c2ddd59a493f717522b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14472: [Flink-20736] Separate implementation of BatchExecLimit,StreamExecLimit,StreamExecRank

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14472:
URL: https://github.com/apache/flink/pull/14472#issuecomment-750005686


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226",
       "triggerID" : "e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238",
       "triggerID" : "78cd30e32d782920ef421aadb46cec2e51a49dd5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e5346d4e2d10ad2102d591e3a8ad606dbdfb3ed3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11226) 
   * 78cd30e32d782920ef421aadb46cec2e51a49dd5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11238) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org