[GitHub] [arrow] westonpace commented on a diff in pull request #34125: GH-34076: [C#] Allow schema fields with duplicate names

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on code in PR #34125:
URL: https://github.com/apache/arrow/pull/34125#discussion_r1107797906


##########
csharp/src/Apache.Arrow/Schema.cs:
##########
@@ -22,32 +22,31 @@ namespace Apache.Arrow
 {
     public partial class Schema
     {
-        public IReadOnlyDictionary<string, Field> Fields
-        {
-            get => _fieldsDictionary;
-        }
+        [Obsolete("Use `FieldList` instead")]
+        public IReadOnlyDictionary<string, Field> Fields => _fieldsDictionary;

Review Comment:
   Do we want to add an `ILookup<string, Field>` which might be handy on wide schemas?  It's still an API break but might be useful.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org