[Proposal] Add a Redis plugin to codebase (OFBIZ-9829)

[Shi Jinghai <hu...@hotmail.com>]

Hi community,

There's a patch on Redis plugin in https://issues.apache.org/jira/browse/OFBIZ-9829.

Redis is key-value in-memory database widely used in Ecommerce and CRM.

Michael asked me to discuss whether it's necessary to include it in OFBiz codebase. If not, I'll revert it.

Thanks for your feedback,

Shi Jinghai

Re: [Proposal] Add a Redis plugin to codebase (OFBIZ-9829)

[Taher Alkhateeb <sl...@gmail.com>]

Hello Shi, thank you for your work on this initiative.

When reviewing the component, I found that it pretty much focused on
implementing three services and it doesn't seem to provide any deep
integration or added value. The services are just to set, get and
delete redis info which is a simple JSON object for initiating
settings. I can't see the added value of this setup so far.

I don't understand the purpose of this component, and I do not
understand why it was committed without getting consensus from the
community. This is actually also true of the pricat component which
was committed without consulting with the community.

My recommendation is to remove both components from the repository,
and discuss their merits with the community first, and if enough
people show interest and approval then we include the code.

On Thu, Oct 12, 2017 at 1:11 PM, Michael Brohl <mi...@ecomify.de> wrote:
> Hi Jinghai,
>
> first of all thanks for your contribution. I appreciate your work, even if I
> do not agree with the process (see Jira issue).
>
> So please understand my critical questions as an attempt to assure a good
> process and quality for the project and not a refusal of your work or this
> plugin in general.
>
> For a proper proposal, please provide more informations on the solution and
> why it is useful for the project. You can see the community as a customer
> and you have to convince us that the solution is worth being introduced to
> OFBiz and being maintained further. In the past, we had several half-baked
> additions to the codebase which were committed and not maintained anymore.
>
> I would like to avoid this and the best way (IMO) is to be more restrictive
> when introducing new code to the project.
>
> For this plugin, at first glance, I'm missing the following informations and
> quality aspects:
>
> - the big picture: the motivation and use cases for this plugin and OFBiz
> integration
> - a documentation (brief descriptions of Redis et al or just links to these
> projects are not a documentation)
> - why you have chosen Redis and the Redisson client and not some other
> - a sample integration into OFBiz (to prove it is working and to show how it
> is used)
> - tests
> - source code documentation
>
> This is just a shot from my first impressions, others may  follow.
>
> Looking forward to a good collaboration on this.
>
> Thanks,
>
> Michael
>
>
> Am 12.10.17 um 03:38 schrieb Shi Jinghai:
>
>> Hi community,
>>
>> There's a patch on Redis plugin in
>> https://issues.apache.org/jira/browse/OFBIZ-9829.
>>
>> Redis is key-value in-memory database widely used in Ecommerce and CRM.
>>
>> Michael asked me to discuss whether it's necessary to include it in OFBiz
>> codebase. If not, I'll revert it.
>>
>> Thanks for your feedback,
>>
>> Shi Jinghai
>>
>>
>
>

Re: [Proposal] Add a Redis plugin to codebase (OFBIZ-9829)

[Michael Brohl <mi...@ecomify.de>]

Hi Jinghai,

first of all thanks for your contribution. I appreciate your work, even 
if I do not agree with the process (see Jira issue).

So please understand my critical questions as an attempt to assure a 
good process and quality for the project and not a refusal of your work 
or this plugin in general.

For a proper proposal, please provide more informations on the solution 
and why it is useful for the project. You can see the community as a 
customer and you have to convince us that the solution is worth being 
introduced to OFBiz and being maintained further. In the past, we had 
several half-baked additions to the codebase which were committed and 
not maintained anymore.

I would like to avoid this and the best way (IMO) is to be more 
restrictive when introducing new code to the project.

For this plugin, at first glance, I'm missing the following informations 
and quality aspects:

- the big picture: the motivation and use cases for this plugin and 
OFBiz integration
- a documentation (brief descriptions of Redis et al or just links to 
these projects are not a documentation)
- why you have chosen Redis and the Redisson client and not some other
- a sample integration into OFBiz (to prove it is working and to show 
how it is used)
- tests
- source code documentation

This is just a shot from my first impressions, others may  follow.

Looking forward to a good collaboration on this.

Thanks,

Michael


Am 12.10.17 um 03:38 schrieb Shi Jinghai:
> Hi community,
>
> There's a patch on Redis plugin in https://issues.apache.org/jira/browse/OFBIZ-9829.
>
> Redis is key-value in-memory database widely used in Ecommerce and CRM.
>
> Michael asked me to discuss whether it's necessary to include it in OFBiz codebase. If not, I'll revert it.
>
> Thanks for your feedback,
>
> Shi Jinghai
>
>