You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/09/14 09:23:11 UTC

DO NOT REPLY [Bug 49924] New: When non-primary node changes into a primary node, isPrimarySession is not changed to true.

https://issues.apache.org/bugzilla/show_bug.cgi?id=49924

           Summary: When non-primary node changes into a primary node,
                    isPrimarySession is not changed to true.
           Product: Tomcat 7
           Version: 7.0.2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Cluster
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: kfujino@apache.org


If BackupManager is used,
when a primary node is switched, 
DeltaSession#isPrimarySession is not changed to true. 

Non-primary node changes into a primary node 
when a primary node is stopped or we get a non-primary session. 

If a primary node is stopped, a primary node is switched. 
In AbstractReplicatedMap, when a primary node is switched, 
MapOwner(BackupManager)#objectMadePrimay is called. 
However, isPrimarySession does not change to true in this method. 
=====BackupManager#objectMadePrimay=====
public void objectMadePrimay(Object key, Object value) {
    if (value!=null && value instanceof DeltaSession) {
        DeltaSession session = (DeltaSession)value;
        synchronized (session) {
            session.access();
            session.endAccess();
        }
    }
}
=====

If we get a non-primary session,  a primary node is switched. 
However, isPrimarySession does not change to true. 
It is only a change of primary node.

I made a patch.
It contains the following. 
isPrimarySession is set to true in BackupManager#objectMadePrimay.
When get() is called in non-primary node, MapOwner#objectMadePrimay is called.


Best regards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 49924] When non-primary node changes into a primary node, isPrimarySession is not changed to true.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49924

Keiichi Fujino <kf...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Keiichi Fujino <kf...@apache.org> 2010-10-05 01:34:45 EDT ---
This fix applied to 6.0, will be in 6.0.30 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 49924] When non-primary node changes into a primary node, isPrimarySession is not changed to true.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49924

--- Comment #1 from Keiichi Fujino <kf...@apache.org> 2010-09-14 03:26:53 EDT ---
Created an attachment (id=26024)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26024)
I made a patch.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 49924] When non-primary node changes into a primary node, isPrimarySession is not changed to true.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49924

--- Comment #2 from Keiichi Fujino <kf...@apache.org> 2010-09-14 03:50:54 EDT ---
Fixed in trunk and proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 49924] When non-primary node changes into a primary node, isPrimarySession is not changed to true.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49924

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Cluster                     |Cluster
            Version|7.0.2                       |6.0.29
            Product|Tomcat 7                    |Tomcat 6
   Target Milestone|---                         |default

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org