[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24464: [SPARK-27439][SQL] Explainging Dataset should show correct resolved plans

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24464: [SPARK-27439][SQL] Explainging Dataset should show correct resolved plans
URL: https://github.com/apache/spark/pull/24464#discussion_r280654719
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -498,7 +498,7 @@ class Dataset[T] private[sql](
    * @since 1.6.0
    */
   def explain(extended: Boolean): Unit = {
-    val explain = ExplainCommand(queryExecution.logical, extended = extended)
+    val explain = ExplainCommand(queryExecution, extended = extended)
 
 Review comment:
   To fix the current bug, I agree with @viirya . I believe this is inevitable. 
   Could you give us some guide for this, @cloud-fan and @gatorsmile ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org