[GitHub] [ignite] Mmuzaf commented on a change in pull request #6960: IGNITE-12193 Add cacheGroup metrics.

[GitBox <gi...@apache.org>]

Mmuzaf commented on a change in pull request #6960: IGNITE-12193 Add cacheGroup metrics.
URL: https://github.com/apache/ignite/pull/6960#discussion_r361330917
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
 ##########
 @@ -1305,6 +1365,23 @@ public boolean isInitial() {
             }
         }
 
+        /** {@inheritDoc} */
+        @Override public boolean onDone(@Nullable Boolean res, @Nullable Throwable err, boolean cancel) {
+            assert !cancel;
+
+            long time = System.currentTimeMillis();
+
+            if (startTime != -1)
+                endTime.compareAndSet(-1, time);
+
+            boolean byThisCall = super.onDone(res, err, cancel);
+
+            if (byThisCall && (res == false || isFailed()))
 
 Review comment:
   Let's change to `res == Boolean.FALSE` to avoid unboxing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services