You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/18 02:46:56 UTC
[GitHub] [kafka] showuon opened a new pull request #10715: KAFKA-9295: increase heartbeat and session timeout
showuon opened a new pull request #10715:
URL: https://github.com/apache/kafka/pull/10715
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10715:
URL: https://github.com/apache/kafka/pull/10715#issuecomment-843681372
@ableegoldman , no problem! Updated! Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10715:
URL: https://github.com/apache/kafka/pull/10715#issuecomment-842799201
@ableegoldman , as discussed, could you help review this PR to increase session timeout? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10715:
URL: https://github.com/apache/kafka/pull/10715#issuecomment-843693730
I'll monitor it and let you know when completed. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10715:
URL: https://github.com/apache/kafka/pull/10715#issuecomment-843771446
Merged to trunk at exactly 11pm PST (May 18th 2021) -- be on the lookout for any failures on builds kicked off after this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10715:
URL: https://github.com/apache/kafka/pull/10715#issuecomment-843766426
Failed test is unrelated and flaky.
```
Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10715:
URL: https://github.com/apache/kafka/pull/10715#issuecomment-842883396
failed test is flaky RaftClusterTest:
```
Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10715:
URL: https://github.com/apache/kafka/pull/10715#issuecomment-843543131
@showuon I don't think we need to increase the heartbeat interval, let's just bump up the session timeout for now. We still want to be relatively quick in our broker requests/responses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #10715: KAFKA-9295: increase heartbeat and session timeout
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10715:
URL: https://github.com/apache/kafka/pull/10715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon edited a comment on pull request #10715: KAFKA-9295: increase heartbeat and session timeout
Posted by GitBox <gi...@apache.org>.
showuon edited a comment on pull request #10715:
URL: https://github.com/apache/kafka/pull/10715#issuecomment-843766426
@ableegoldman , Failed test is unrelated and flaky. Thanks.
```
Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org