You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/06 19:19:11 UTC
[GitHub] [kafka] jthurne opened a new pull request #10491: MINOR: Switch to using the Gradle RAT plugin
jthurne opened a new pull request #10491:
URL: https://github.com/apache/kafka/pull/10491
The Gradle RAT plugin properly declares inputs and outputs and is also
cachable. This also relieves the Kafka developers from maintaining the build
integration with RAT.
The generated RAT report is identical to the one generated previously. The only
difference is the RAT report name: the RAT plugin sets the HTML report name to
`index.html` (still under `build/rat`).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #10491:
URL: https://github.com/apache/kafka/pull/10491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jthurne commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814916880
I'm looking into the build failures on this one.
At first glance, the pr-merge build failed due to one of the test tasks crashing. Presumably that's not related at all to this change, which doesn't touch the test tasks.
Some of the other failures site a RAT license check failure. I'm looking into this to make sure it isn't something new introduced by switching to the RAT plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jthurne commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814377383
@ijuma another one for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-817450432
Started another build (the previous got canceled due to environmental issues).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jthurne commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-817901760
Interesting. When I run the rat task locally, those three files are identified (correctly) as binary files and RAT skips them.
I'm not sure why they are being detected as text files on CI. But an easy workaround is to explicitly exclude that directory. I've pushed up a commit that does just that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jthurne commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814378302
Full disclosure: I'm an engineer that works for Gradle (on [Gradle Enterprise](https://gradle.com/), and I found these optimizations while using the project to test out Gradle Enterprise features.
I put this change in a separate PR from [the other build optimizations](https://github.com/apache/kafka/pull/10490) since it is a slightly larger change, and since the HTML report name changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-817501577
@jthurne This change causes new failures:
> [2021-04-12T03:23:02.541Z] > A failure occurred while executing org.nosphere.apache.rat.RatWork
>
> [2021-04-12T03:23:02.541Z] > Apache Rat audit failure - 3 unapproved licenses
>
> [2021-04-12T03:23:02.541Z] See file:///home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10491/build/rat/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jthurne commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-817844704
> @jthurne This change causes new failures:
Indeed. Unfortunately, I have been unable to reproduce them locally. One downside to the RAT plugin is that it doesn't output the files that fail the check to the build log. That makes this hard to diagnose since it seems to only happens on the CI server.
My suspicion, however, is that this has something to do with file encoding. I'll keep digging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-817860347
This is the output:
> /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10491/clients/src/test/resources/serializedData/topicPartitionSerializedfile
> /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10491/clients/src/test/resources/serializedData/offsetAndMetadataWithLeaderEpoch
> /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10491/clients/src/test/resources/serializedData/offsetAndMetadataBeforeLeaderEpoch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jthurne commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin
Posted by GitBox <gi...@apache.org>.
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814950598
I believe the license failures were caused by a different change to trunk that has since been fixed. I merged the latest trunk HEAD into this PR to re-trigger CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org