You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2016/12/08 00:56:17 UTC

[1/5] cordova-plugin-battery-status git commit: CB-11832 Incremented plugin version.

Repository: cordova-plugin-battery-status
Updated Branches:
  refs/heads/1.2.x 4f9044ec3 -> 59189285b


CB-11832 Incremented plugin version.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/commit/5d69bedf
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/tree/5d69bedf
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/diff/5d69bedf

Branch: refs/heads/1.2.x
Commit: 5d69bedf81a7063dbc1a9a52ddf6d83d866748bf
Parents: 4f9044e
Author: Steve Gill <st...@gmail.com>
Authored: Fri Sep 9 16:08:02 2016 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Fri Sep 9 16:08:02 2016 -0700

----------------------------------------------------------------------
 package.json     | 2 +-
 plugin.xml       | 2 +-
 tests/plugin.xml | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/5d69bedf/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index 6627f34..1732ca3 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-battery-status",
-  "version": "1.2.0",
+  "version": "1.2.1-dev",
   "description": "Cordova Battery Plugin",
   "cordova": {
     "id": "cordova-plugin-battery-status",

http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/5d69bedf/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 7fe9f34..dad97a4 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
       id="cordova-plugin-battery-status"
-      version="1.2.0">
+      version="1.2.1-dev">
     <name>Battery</name>
     <description>Cordova Battery Plugin</description>
     <license>Apache 2.0</license>

http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/5d69bedf/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index 3e5bdda..e1f129f 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -22,7 +22,7 @@
     xmlns:rim="http://www.blackberry.com/ns/widgets"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="cordova-plugin-battery-status-tests"
-    version="1.2.0">
+    version="1.2.1-dev">
     <name>Cordova Battery Plugin Tests</name>
     <license>Apache 2.0</license>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[5/5] cordova-plugin-battery-status git commit: CB-12224 Updated version and RELEASENOTES.md for release 1.2.1

Posted by sh...@apache.org.
CB-12224 Updated version and RELEASENOTES.md for release 1.2.1


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/commit/59189285
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/tree/59189285
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/diff/59189285

Branch: refs/heads/1.2.x
Commit: 59189285b60dacf6433aafa7294178598fb920a4
Parents: 248f96f
Author: Shazron Abdullah <sh...@apache.org>
Authored: Wed Dec 7 16:39:43 2016 -0800
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Wed Dec 7 16:39:43 2016 -0800

----------------------------------------------------------------------
 RELEASENOTES.md  | 131 ++++++++++++++++++++++++++++++++++++++++++++++++++
 package.json     |   2 +-
 plugin.xml       |   2 +-
 tests/plugin.xml |   2 +-
 4 files changed, 134 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/59189285/RELEASENOTES.md
----------------------------------------------------------------------
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
index 3abde30..7f627cf 100644
--- a/RELEASENOTES.md
+++ b/RELEASENOTES.md
@@ -20,6 +20,137 @@
 -->
 # Release Notes
 
+### 1.2.1 (Dec 07, 2016)
+* [CB-8929](https://issues.apache.org/jira/browse/CB-8929) Fix failing tests on iOS
+* [CB-8929](https://issues.apache.org/jira/browse/CB-8929) Use PowerManager to get battery state on Win 10
+* [CB-11917](https://issues.apache.org/jira/browse/CB-11917) - Remove pull request template checklist item: "iCLA has been submitted\u2026"
+* [CB-11832](https://issues.apache.org/jira/browse/CB-11832) Incremented plugin version.
+* [CB-11832](https://issues.apache.org/jira/browse/CB-11832) Updated version and RELEASENOTES.md for release 1.2.0
+* [CB-11795](https://issues.apache.org/jira/browse/CB-11795) Add 'protective' entry to cordovaDependencies
+* Plugin uses Android Log class and not Cordova LOG class
+* Add badges for paramedic builds on Jenkins
+* Add pull request template.
+* [CB-10996](https://issues.apache.org/jira/browse/CB-10996) Adding front matter to README.md
+* [CB-11091](https://issues.apache.org/jira/browse/CB-11091) Incremented plugin version.
+*  Updated version and RELEASENOTES.md for release 1.1.2
+* [CB-10720](https://issues.apache.org/jira/browse/CB-10720) Reorganizing and rewording docs.
+* [CB-10636](https://issues.apache.org/jira/browse/CB-10636) Add JSHint for plugins
+* chore: edit package.json license to match SPDX id
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Incremented plugin version.
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) linked issues in RELEASENOTES.md
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated version and RELEASENOTES.md for release 1.1.1
+* removed r prefix from tags
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated RELEASENOTES to be newest to oldest
+* Actually fixing the contribute link.
+* Fixing contribute link.
+* remove travis-ci integration
+* [CB-9192](https://issues.apache.org/jira/browse/CB-9192) Incremented plugin version.
+* [CB-9202](https://issues.apache.org/jira/browse/CB-9202) updated repo url to github mirror in package.json
+* [CB-9192](https://issues.apache.org/jira/browse/CB-9192) Updated version and RELEASENOTES.md for release 1.1.0
+* added missing license headers
+* [CB-7953](https://issues.apache.org/jira/browse/CB-7953) Add cordova-plugin-battery-status support for browser platform
+* [CB-9128](https://issues.apache.org/jira/browse/CB-9128) cordova-plugin-battery-status documentation translation: cordova-plugin-battery-status
+* attempt to fix npm issue
+* [CB-8858](https://issues.apache.org/jira/browse/CB-8858) Incremented plugin version.
+* [CB-8858](https://issues.apache.org/jira/browse/CB-8858) Updated version in package.json for release 1.0.0
+* Revert "CB-8858 Incremented plugin version."
+* [CB-8858](https://issues.apache.org/jira/browse/CB-8858) Incremented plugin version.
+* [CB-8858](https://issues.apache.org/jira/browse/CB-8858) Updated version and RELEASENOTES.md for release 1.0.0
+* [CB-8746](https://issues.apache.org/jira/browse/CB-8746) gave plugin major version bump
+* [CB-8808](https://issues.apache.org/jira/browse/CB-8808) Fixed tests to pass on Windows Phone 8.1
+* [CB-8831](https://issues.apache.org/jira/browse/CB-8831) Adds extra check for available API on Windows
+* [CB-8653](https://issues.apache.org/jira/browse/CB-8653) properly updated translated docs to use new id
+* [CB-8683](https://issues.apache.org/jira/browse/CB-8683) changed plugin-id to pacakge-name
+* [CB-8653](https://issues.apache.org/jira/browse/CB-8653) updated translated docs to use new id
+* Use TRAVIS_BUILD_DIR, install paramedic by npm
+* Doc correction, Use the apostrophe to show possession
+* Fix travis+paramedic pathing issue
+* add Android+FireOS warning to tell devs that prolonged use will drain the battery.
+* [CB-7971](https://issues.apache.org/jira/browse/CB-7971) Add cordova-plugin-battery-status support for Windows Phone 8.1
+* [CB-8653](https://issues.apache.org/jira/browse/CB-8653) Updated Readme
+* [CB-8659](https://issues.apache.org/jira/browse/CB-8659) ios: 4.0.x Compatibility: Remove use of initWithWebView method
+* added apache/travis badge - will not show until INFRA updates the github integration
+* add travis.yml for CI with paramedic
+* [CB-8538](https://issues.apache.org/jira/browse/CB-8538) Added package.json file
+* [CB-8110](https://issues.apache.org/jira/browse/CB-8110) Incremented plugin version.
+* [CB-8110](https://issues.apache.org/jira/browse/CB-8110) Updated version and RELEASENOTES.md for release 0.2.12
+* [CB-7976](https://issues.apache.org/jira/browse/CB-7976) Android: Use webView's context rather than Activity's context for intent receiver
+* [CB-7700](https://issues.apache.org/jira/browse/CB-7700) cordova-plugin-battery-status documentation translation: cordova-plugin-battery-status
+* [CB-7571](https://issues.apache.org/jira/browse/CB-7571) Bump version of nested plugin to match parent plugin
+* [CB-7571](https://issues.apache.org/jira/browse/CB-7571) Incremented plugin version.
+* [CB-7571](https://issues.apache.org/jira/browse/CB-7571) Updated version and RELEASENOTES.md for release 0.2.11
+* CB-7249cordova-plugin-battery-status documentation translation: cordova-plugin-battery-status
+* cb6724re-add accidental removed of var keyword
+* [CB-6957](https://issues.apache.org/jira/browse/CB-6957) renamed folder to tests + added nested plugin.xml
+* [CB-7244](https://issues.apache.org/jira/browse/CB-7244) Incremented plugin version.
+* [CB-7244](https://issues.apache.org/jira/browse/CB-7244) Updated version and RELEASENOTES.md for release 0.2.10
+* CB-7249cordova-plugin-battery-status documentation translation: cordova-plugin-battery-status
+* added documentation for manual tests
+* [CB-6957](https://issues.apache.org/jira/browse/CB-6957) Style improvements on Manual tests
+* [CB-6957](https://issues.apache.org/jira/browse/CB-6957) Ported Battery-status manual & automated
+* CB-6127lisa7cordova-plugin-consolecordova-plugin-battery-status documentation translation: cordova-plugin-battery-status
+* Minor doc corrections
+* [CB-6877](https://issues.apache.org/jira/browse/CB-6877) Incremented plugin version.
+* [CB-6877](https://issues.apache.org/jira/browse/CB-6877) Updated version and RELEASENOTES.md for release 0.2.9
+* [CB-6794](https://issues.apache.org/jira/browse/CB-6794) Add license for CONTRIBUTING.md
+* documentation translation: cordova-plugin-battery-status
+* Lisa testing pulling in plugins for plugin: cordova-plugin-battery-status
+* Lisa testing pulling in plugins for plugin: cordova-plugin-battery-status
+* [CB-6721](https://issues.apache.org/jira/browse/CB-6721) ignore null values if previous value was not null
+* [CB-6721](https://issues.apache.org/jira/browse/CB-6721) Test for batterycritical change before batterylow change
+* Updated documentation. Added support for mozBattery.
+* [CB-5611](https://issues.apache.org/jira/browse/CB-5611) firefoxos: battery-status plugin
+* CB-4519, [CB-4520](https://issues.apache.org/jira/browse/CB-4520) low+critical weren't firing when level went from 21->19, and were when level went 19->20
+* [CB-6491](https://issues.apache.org/jira/browse/CB-6491) add CONTRIBUTING.md
+* Lisa testing pulling in plugins for plugin: cordova-plugin-battery-status
+* Lisa testing pulling in plugins for plugin: cordova-plugin-battery-status
+* [CB-6452](https://issues.apache.org/jira/browse/CB-6452) Incremented plugin version on dev branch.
+* [CB-6452](https://issues.apache.org/jira/browse/CB-6452) Updated version and RELEASENOTES.md for release 0.2.8
+* [CB-6465](https://issues.apache.org/jira/browse/CB-6465) Add license headers to Tizen code
+* [CB-6460](https://issues.apache.org/jira/browse/CB-6460) Update license headers
+* Add NOTICE file
+* [CB-5980](https://issues.apache.org/jira/browse/CB-5980) Incremented plugin version on dev branch.
+* Lisa testing pulling in plugins for plugin: cordova-plugin-battery-status
+* Lisa testing pulling in plugins for plugin: cordova-plugin-battery-status
+* [CB-5980](https://issues.apache.org/jira/browse/CB-5980) Updated version and RELEASENOTES.md for release 0.2.7
+* Add Tizen plugin.
+* Delete stale test/ directory
+* [CB-5719](https://issues.apache.org/jira/browse/CB-5719) Incremented plugin version on dev branch.
+* [CB-5719](https://issues.apache.org/jira/browse/CB-5719) Updated version and RELEASENOTES.md for release 0.2.6
+* Fix typo in docs H2 -> H3
+* [CB-5658](https://issues.apache.org/jira/browse/CB-5658) Update license comment formatting of doc/index.md.
+* [CB-5658](https://issues.apache.org/jira/browse/CB-5658) Remove Apache license comment from README.md.
+* Fix up Markdown license to actually be in comments.
+* [CB-5658](https://issues.apache.org/jira/browse/CB-5658) Add doc/index.md for Battery Status.
+* [CB-5658](https://issues.apache.org/jira/browse/CB-5658) Delete stale snapshot of plugin docs
+* [CB-5565](https://issues.apache.org/jira/browse/CB-5565) Incremented plugin version on dev branch.
+* [CB-5565](https://issues.apache.org/jira/browse/CB-5565) Updated version and RELEASENOTES.md for release 0.2.5
+* Merged WP8 support for level, but #def'd it out so the same code runs on wp7.  Updated docs to reflect WP8 support for battery level, and low+critical events
+* wp8 add support in level
+* add ubuntu platform
+* 1. Updated platform name amazon->amazon-fireos. Deleted src files. 2. Change to use amazon-fireos as the platform if user agent string contains 'cordova-amazon-fireos'
+* [CB-5188](https://issues.apache.org/jira/browse/CB-5188)
+* CB-5188:Updated version and RELEASENOTES.md for release 0.2.4
+* [CB-5128](https://issues.apache.org/jira/browse/CB-5128) added repo + issue tag to plugin.xml for battery status plugin
+* [CB-4915](https://issues.apache.org/jira/browse/CB-4915) Incremented plugin version on dev branch.
+* [CB-4915](https://issues.apache.org/jira/browse/CB-4915) Updated version and RELEASENOTES.md for release 0.2.3
+* [CB-4889](https://issues.apache.org/jira/browse/CB-4889) bumping&resetting version
+* [CB-4752](https://issues.apache.org/jira/browse/CB-4752) Incremented plugin version on dev branch.
+* [CB-4889](https://issues.apache.org/jira/browse/CB-4889) renaming org.apache.cordova.core.battery-status to org.apache.cordova.battery-status
+* reverting on master
+* [CB-4889](https://issues.apache.org/jira/browse/CB-4889) renaming org.apache.cordova.core.battery-status to org.apache.cordova.battery-status
+* [CB-4752](https://issues.apache.org/jira/browse/CB-4752) Updated version and changelog
+* [CB-4432](https://issues.apache.org/jira/browse/CB-4432) copyright notice change
+* [CB-4432](https://issues.apache.org/jira/browse/CB-4432) copyright notice change
+* [CB-4595](https://issues.apache.org/jira/browse/CB-4595) updated version
+* reverted name element to be human readable
+* [CB-4417](https://issues.apache.org/jira/browse/CB-4417) Move cordova-plugin-battery-status to its own Java package.
+* updated namespace
+* updated name tag and readme
+* [plugin.xml] standardizing license + meta
+* [license] adding apache license file
+* updating plugin.xml with registry data
+
 ### 1.2.0 (Sep 08, 2016)
 * [CB-11795](https://issues.apache.org/jira/browse/CB-11795) Add 'protective' entry to cordovaDependencies
 * Plugin uses Android Log class and not Cordova LOG class

http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/59189285/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index 1732ca3..839c086 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-battery-status",
-  "version": "1.2.1-dev",
+  "version": "1.2.1",
   "description": "Cordova Battery Plugin",
   "cordova": {
     "id": "cordova-plugin-battery-status",

http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/59189285/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index dad97a4..2b122e6 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -20,7 +20,7 @@
 
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
       id="cordova-plugin-battery-status"
-      version="1.2.1-dev">
+      version="1.2.1">
     <name>Battery</name>
     <description>Cordova Battery Plugin</description>
     <license>Apache 2.0</license>

http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/59189285/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index e1f129f..5cbd9da 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -22,7 +22,7 @@
     xmlns:rim="http://www.blackberry.com/ns/widgets"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="cordova-plugin-battery-status-tests"
-    version="1.2.1-dev">
+    version="1.2.1">
     <name>Cordova Battery Plugin Tests</name>
     <license>Apache 2.0</license>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[3/5] cordova-plugin-battery-status git commit: CB-8929 Use PowerManager to get battery state on Win 10

Posted by sh...@apache.org.
CB-8929 Use PowerManager to get battery state on Win 10

This closes #42


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/commit/85c6f507
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/tree/85c6f507
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/diff/85c6f507

Branch: refs/heads/1.2.x
Commit: 85c6f507a3e4b8640ae81eac3be953e6d7cf19ab
Parents: e7c1a16
Author: Vladimir Kotikov <ko...@gmail.com>
Authored: Mon Nov 7 14:46:20 2016 +0300
Committer: Vladimir Kotikov <ko...@gmail.com>
Committed: Tue Nov 8 17:09:07 2016 +0300

----------------------------------------------------------------------
 README.md                   |  6 +++---
 src/windows/BatteryProxy.js | 42 +++++++++++++++++++++++++++++++++++++++-
 tests/tests.js              | 40 ++++++++++++++++++++++----------------
 3 files changed, 67 insertions(+), 21 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/85c6f507/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index 8301f45..30ace99 100644
--- a/README.md
+++ b/README.md
@@ -65,7 +65,7 @@ Fires when the battery charge percentage changes by at least 1 percent, or when
 - Android
 - BlackBerry 10
 - Windows Phone 7 and 8
-- Windows (Windows Phone 8.1 only)
+- Windows (Windows Phone 8.1 and Windows 10)
 - Firefox OS
 - Browser (Chrome, Firefox, Opera)
 
@@ -100,7 +100,7 @@ Fires when the battery charge percentage reaches the low charge threshold. This
 - Android
 - BlackBerry 10
 - Firefox OS
-- Windows (Windows Phone 8.1 only)
+- Windows (Windows Phone 8.1 and Windows 10)
 - Browser (Chrome, Firefox, Opera)
 
 ### Quirks: Windows Phone 8.1
@@ -126,7 +126,7 @@ Fires when the battery charge percentage reaches the critical charge threshold.
 - Android
 - BlackBerry 10
 - Firefox OS
-- Windows (Windows Phone 8.1 only)
+- Windows (Windows Phone 8.1 and Windows 10)
 - Browser (Chrome, Firefox, Opera)
 
 ### Quirks: Windows Phone 8.1

http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/85c6f507/src/windows/BatteryProxy.js
----------------------------------------------------------------------
diff --git a/src/windows/BatteryProxy.js b/src/windows/BatteryProxy.js
index ed91bcb..9f5ac66 100644
--- a/src/windows/BatteryProxy.js
+++ b/src/windows/BatteryProxy.js
@@ -19,7 +19,47 @@
  *
  */
 
-/* global WinJS, BatteryStatus */
+/* global Windows, WinJS, BatteryStatus */
+
+var PowerManager = Windows && Windows.System &&
+    Windows.System.Power && Windows.System.Power.PowerManager;
+
+if (PowerManager) {
+    var pluginCallback;
+    var reportStatus = function () {
+        if (!pluginCallback) {
+            return;
+        }
+
+        pluginCallback({
+            level: PowerManager.remainingChargePercent,
+            isPlugged: PowerManager.powerSupplyStatus !== Windows.System.Power.PowerSupplyStatus.notPresent
+        }, { keepCallback: true });
+    };
+
+    var BatteryWin10 = {
+        start: function (win, fail) {
+            pluginCallback = win;
+            PowerManager.addEventListener('remainingchargepercentchanged', reportStatus);
+            PowerManager.addEventListener('powersupplystatuschanged', reportStatus);
+
+            reportStatus();
+        },
+
+        stop: function () {
+            if (pluginCallback) {
+                PowerManager.removeEventListener('remainingchargepercentchanged', reportStatus);
+                PowerManager.removeEventListener('powersupplystatuschanged', reportStatus);
+            }
+
+            pluginCallback = null;
+        }
+    };
+
+    require("cordova/exec/proxy").add("Battery", BatteryWin10);
+    return;
+}
+
 
 var stopped;
 

http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/85c6f507/tests/tests.js
----------------------------------------------------------------------
diff --git a/tests/tests.js b/tests/tests.js
index ad21d3b..69211ad 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -20,16 +20,22 @@
  */
 
 /* jshint jasmine: true */
-/* global WinJS */
+/* global Windows, WinJS */
 
 exports.defineAutoTests = function () {
-    var isWindowsStore = (cordova.platformId == "windows8") || (cordova.platformId == "windows" && !WinJS.Utilities.isPhone),
-        onEvent;
+    var hasPowerManagerAPI = Windows && Windows.System &&
+        Windows.System.Power && Windows.System.Power.PowerManager;
+
+    var batteryStatusUnsupported = cordova.platformId === "windows8" ||
+        // We don't test battery status on Windows when there is no corresponding APIs available
+        cordova.platformId === "windows" && !(hasPowerManagerAPI || WinJS.Utilities.isPhone);
+
+    var onEvent;
 
     describe('Battery (navigator.battery)', function () {
 
         it("battery.spec.1 should exist", function () {
-            if (isWindowsStore) {
+            if (batteryStatusUnsupported) {
                 pending('Battery status is not supported on windows store');
             }
 
@@ -42,7 +48,7 @@ exports.defineAutoTests = function () {
         describe("batterystatus", function () {
 
             afterEach(function () {
-                if (!isWindowsStore) {
+                if (!batteryStatusUnsupported) {
                     try {
                         window.removeEventListener("batterystatus", onEvent, false);
                     }
@@ -53,7 +59,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.2 should fire batterystatus events", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 
@@ -78,7 +84,7 @@ exports.defineAutoTests = function () {
         describe("batterylow", function () {
 
             afterEach(function () {
-                if (!isWindowsStore) {
+                if (!batteryStatusUnsupported) {
                     try {
                         window.removeEventListener("batterylow", onEvent, false);
                     }
@@ -89,7 +95,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.3 should fire batterylow event (30 -> 20)", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 
@@ -116,7 +122,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.3.1 should fire batterylow event (30 -> 19)", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 
@@ -142,7 +148,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.3.2 should not fire batterylow event (5 -> 20)", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 
@@ -168,7 +174,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.3.3 batterylow event(21 -> 20) should not fire if charging", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 
@@ -197,7 +203,7 @@ exports.defineAutoTests = function () {
         describe("batterycritical", function () {
 
             afterEach(function () {
-                if (!isWindowsStore) {
+                if (!batteryStatusUnsupported) {
                     try {
                         window.removeEventListener("batterycritical", onEvent, false);
                     }
@@ -208,7 +214,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.4 should fire batterycritical event (19 -> 5)", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 
@@ -235,7 +241,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.4.1 should fire batterycritical event (19 -> 4)", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 
@@ -262,7 +268,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.4.2 should fire batterycritical event (100 -> 4) when decreases", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 
@@ -288,7 +294,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.4.3 should not fire batterycritical event (4 -> 5) when increasing", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 
@@ -314,7 +320,7 @@ exports.defineAutoTests = function () {
             });
 
             it("battery.spec.4.4 should not fire batterycritical event (6 -> 5) if charging", function (done) {
-                if (isWindowsStore) {
+                if (batteryStatusUnsupported) {
                     pending('Battery status is not supported on windows store');
                 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[2/5] cordova-plugin-battery-status git commit: CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…"

Posted by sh...@apache.org.
CB-11917 - Remove pull request template checklist item: "iCLA has been submitted\u2026"

 This closes #40


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/commit/e7c1a16b
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/tree/e7c1a16b
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/diff/e7c1a16b

Branch: refs/heads/1.2.x
Commit: e7c1a16b37ab803be7a7838ab91a795d89a898b1
Parents: 5d69bed
Author: Shazron Abdullah <sh...@gmail.com>
Authored: Wed Sep 28 01:36:39 2016 -0700
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Tue Oct 4 21:31:57 2016 -0700

----------------------------------------------------------------------
 .github/PULL_REQUEST_TEMPLATE.md | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/e7c1a16b/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 4bd6da9..91582f4 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -17,7 +17,6 @@ Thanks!
 
 
 ### Checklist
-- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
 - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
 - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
 - [ ] Added automated test coverage as appropriate for this change.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[4/5] cordova-plugin-battery-status git commit: CB-8929 Fix failing tests on iOS

Posted by sh...@apache.org.
CB-8929 Fix failing tests on iOS


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/commit/248f96fc
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/tree/248f96fc
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/diff/248f96fc

Branch: refs/heads/1.2.x
Commit: 248f96fcdd98e02a69e1d82b7a53bfdfed510a08
Parents: 85c6f50
Author: Vladimir Kotikov <ko...@gmail.com>
Authored: Thu Nov 10 10:14:42 2016 +0300
Committer: Vladimir Kotikov <ko...@gmail.com>
Committed: Thu Nov 10 10:14:42 2016 +0300

----------------------------------------------------------------------
 tests/tests.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-battery-status/blob/248f96fc/tests/tests.js
----------------------------------------------------------------------
diff --git a/tests/tests.js b/tests/tests.js
index 69211ad..428208f 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -23,8 +23,9 @@
 /* global Windows, WinJS */
 
 exports.defineAutoTests = function () {
-    var hasPowerManagerAPI = Windows && Windows.System &&
-        Windows.System.Power && Windows.System.Power.PowerManager;
+    var hasPowerManagerAPI = cordova.platformId === "windows" &&
+        Windows && Windows.System && Windows.System.Power &&
+        Windows.System.Power.PowerManager;
 
     var batteryStatusUnsupported = cordova.platformId === "windows8" ||
         // We don't test battery status on Windows when there is no corresponding APIs available


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org